Repository navigation
Merge fix/sdk-7756-percy-v8 - #241
Merged
Merged
Conversation
Ports the v9 Percy fixes (#210, #228) to the v8 line: - Route web `snapshot` to @percy/webdriverio instead of @percy/selenium-webdriver (whose Selenium-only APIs a WebdriverIO browser does not provide), and add @percy/webdriverio ^3.3.4 (3.3.3 shipped without _iframe_shim.js and failed to load; fixed in 3.3.4). - Bump @percy/selenium-webdriver to ^2.2.8 so the Automate percyScreenshot path stops resolving to the broken 2.2.6/2.2.7, which added an unguarded top-level require('selenium-webdriver') and silently disabled Percy on WebdriverIO. - Wrap all Percy entry points so their errors are logged rather than thrown into the user's test; PERCY_RAISE_ERROR=true restores throwing. - Document the percy / percyCaptureMode options in the README. SDK-7756 Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
|
Important Review skippedAuto reviews are disabled on this repository. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: Central YAML (base), Organization UI (inherited), Workspace UI (inherited) Review profile: ASSERTIVE Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Merge into sdk_v8_pre_prod :by automationbs