Repository navigation
Relative paths #2
Description
This seems to be a common issue with babel plugins, we're doing relative reads (or dotenv ends up doing relative read), so a path with something like '../../.env' (lerna setup, I know :() starts failing.
Solved in a fork but wondering how to handle or whether to relay upstream.
Activity
brysgo commentedon Sep 8, 2017
Thanks for the heads up, you can always open a PR with WIP in the title and we can discuss. In the meantime I will look at your branch and think about it.
brysgo commentedon Sep 10, 2017
Just looked at your patch, I will merge it if you submit a PR.
blackxored commentedon Sep 10, 2017
brysgo commentedon Sep 11, 2017
Not sure I understand the scenario you are thinking of. If I recall correctly, what you've done is check for
..in the path and resolve it using the node API if it has dots. Did I miss read your solution?blackxored commentedon Sep 12, 2017
brysgo commentedon Sep 12, 2017
You are right, I made some faulty assumptions about the adoption of this package. If you think it is a broader question of babel plugins, it may be worth asking @hzoo.
brysgo commentedon Sep 16, 2017
@blackxored - I just added a test suite with a simple test, obviously it will need more test cases, but now at least it is there and running in CI. You made me realize this has wider adoption than I thought, so I am going to put a little effort into cleaning it up a bit.