Repository navigation
fix: ty() of null externref and exnref values - #14623
Merged
rvolosatovs merged 1 commit intoOct 9, 2026
Merged
Conversation
alexcrichton
approved these changes
Oct 9, 2026
`Val::ExternRef(None).ty()` returned `(ref null nofunc)` instead of `(ref null noextern)`, and `Ref::Exn(None).ty()` returned `(ref null none)` instead of `(ref null noexn)`. Neither type is matched by the value it was computed from, so e.g. creating a global with `GlobalType::new(v.ty(&store)?, ..)` and `v` as the initial value failed for a null externref. Assisted-by: claude:claude-opus-5-5 Signed-off-by: Roman Volosatovs <rvolosatovs@riseup.net>
rvolosatovs
force-pushed
the
fix/null-ref-val-ty
branch
from
October 9, 2026 15:40
98242fa to
e558b11
Compare
rvolosatovs
marked this pull request as ready for review
October 9, 2026 15:41
rvolosatovs
enabled auto-merge
October 9, 2026 15:41
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Val::ExternRef(None).ty()returned(ref null nofunc)instead of(ref null noextern), andRef::Exn(None).ty()returned(ref null none)instead of(ref null noexn). Neither type is matched by the value it was computed from, so e.g. creating a global withGlobalType::new(v.ty(&store)?, ..)andvas the initial value failed for a null externref.See https://webassembly.github.io/spec/core/text/types.html#reference-types