Conversation
changes in dependencies |
ee8f7e9 to
28a93ad
Compare
3057b04 to
c0e5234
Compare
|
@cursor review |
c0e5234 to
aa69530
Compare
aa69530 to
45f0d77
Compare
|
@cursor review |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes using default effort and found 2 potential issues.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 45f0d77. Configure here.
|
|
||
| ./build_torch.sh | ||
|
|
||
| ./build_scanqr.sh |
There was a problem hiding this comment.
macOS omits built scanner library
Medium Severity
macOS now builds simple.xcframework via build_scanqr.sh, but that library is never added to the macOS Xcode project. iOS embeds it in the app bundle through Copy Files; macOS has no matching embed for simple.xcframework or libsimple. After the fast_scanner bump, macOS QR scanning can fail at runtime because the native scanner library is not in the app.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 45f0d77. Configure here.
| if (capture != null && | ||
| capture.barcodes.any((barcode) => barcode.rawValue?.trim().isNotEmpty ?? false)) { | ||
| _handleBarcode(capture); | ||
| return; |
There was a problem hiding this comment.
Gallery scan pops empty barcode
Low Severity
Gallery success only checks that some barcode has a non-empty rawValue, then _handleBarcode pops barcodes.firstOrNull. If the first entry is empty or null and a later one is valid, the scanner closes with a null or blank result and callers treat that as a cancel, so a readable gallery QR is dropped.
Additional Locations (1)
Reviewed by Cursor Bugbot for commit 45f0d77. Configure here.


Description
Please include a summary of the changes and which issue is fixed / feature is added.
Pull Request - Checklist
Note
Medium Risk
Native library and scanner plugin upgrades affect QR/decode paths on all platforms; dropping rawBytes and changing launchMode could alter edge-case scan results or Android deep-link/back-stack behavior.
Overview
Updates the
fast_scannergit dependency and wires in thescanqr_c_gozxingnative decoder (libsimple.so/simple.xcframework) via newprepare_scanqrand platform build scripts, Android Docker cache layers, and iOS Xcode copy/embed steps.On the scan UI, gallery import is enabled on
ScanPageusingImagePickerandcontroller.analyzeImage, with user-facing “No QR code found” errors and camera resume after failure. Successful scans now returnrawValueonly (norawBytesfallback) inScanPageandqr_scanner.dart.Android
MainActivitylaunchModechanges fromsingleInstancetosingleTask, likely to improve activity stacking when returning from the gallery picker.Reviewed by Cursor Bugbot for commit 45f0d77. Bugbot is set up for automated code reviews on this repo. Configure here.