Skip to content

chore: upgrade ESLint to v9 and separate formatting checks - #1159

Merged
troZee merged 2 commits into
feat/rn-87-vanillafrom
chore/eslint9-flat-config
Oct 8, 2026
Merged

troZee merged 2 commits into
feat/rn-87-vanillafrom
chore/eslint9-flat-config

Conversation

@krozniata

Copy link
Copy Markdown
Member

Summary

Test Plan

What's required for testing (prerequisites)?

What are the steps to reproduce (after prerequisites)?

Compatibility

OS Implemented
iOS ✅❌
Android ✅❌

Checklist

  • I have tested this on a device and a simulator
  • I added the documentation in README.md
  • I updated the typed files (TS and Flow)

@krozniata
krozniata added this pull request to stack #1160 October 7, 2026 10:39
@krozniata
krozniata force-pushed the chore/eslint9-flat-config branch from 3fc5959 to ca10ef3 Compare October 7, 2026 10:54
@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🟢 e2e: 11 passed

All 11 tests in 9 files
Test Time
🟢 tests/basic-pager.e2e.ts · 3 passed 1m 51s
🟢 basic pager › in LTR › pages horizontally 37.0s
🟢 basic pager › in LTR › pages vertically 32.5s
🟢 basic pager › in RTL › pages horizontally with the reversed gesture 41.5s
🟢 tests/issues/issue-1083-modal-set-page.e2e.ts · 1 passed 13.2s
🟢 setPage called behind a native-stack modal lands on the requested page 13.2s
🟢 tests/issues/issue-1098-nested-pager.e2e.ts · 1 passed 13.9s
🟢 outer pager stays responsive after its page count changes around a nested pager 13.9s
🟢 tests/material-top-bar.e2e.ts · 1 passed 11.0s
🟢 material top tabs survive a native-stack push and pop 11.0s
🟢 tests/nested-pager-view.e2e.ts · 1 passed 10.9s
🟢 nested horizontal and vertical pagers scroll independently 10.9s
🟢 tests/on-page-selected.e2e.ts · 1 passed 12.1s
🟢 onPageSelected fires an alert for every page change 12.1s
🟢 tests/scrollable-pager-view.e2e.ts · 1 passed 16.6s
🟢 pager inside a ScrollView keeps its page across vertical scrolls 16.6s
🟢 tests/smoke.e2e.ts · 1 passed 8.9s
🟢 horizontal pager pages with the panel buttons 8.9s
🟢 tests/tab-view-inside-scroll-view.e2e.ts · 1 passed 12.9s
🟢 TabView inside a ScrollView swipes tabs and scrolls the page 12.9s

e2e 0.18.0 · 3m 32s · android · run artifacts

@github-actions

github-actions Bot commented Oct 7, 2026 •

Copy link
Copy Markdown

🔴 e2e: 1 failed, 12 passed

🔴 basic pager › in LTR › pages horizontally
tests/support/basic-pager.ts:34

ENGINE_FAILURE at step 10 of 10: expect.toBeVisible getByTestId("pageNumber0"), after 1m 30s

snapshot failed: Daemon request timed out Hint: Retry with --debug and check daemon diagnostics logs. The timed-out snapshot request was canceled; the daemon was kept alive so the session can still be closed or inspected.

  • Screen: com.pagerviewexample / Basic Example

Evidence: log

All 13 tests in 11 files
Test Time
🔴 tests/basic-pager.e2e.ts · 1 failed, 2 passed 4m 11s
🔴 basic pager › in LTR › pages horizontally 1m 54s
🟢 basic pager › in LTR › pages vertically 1m 25s
🟢 basic pager › in RTL › pages horizontally with the reversed gesture 52.7s
🟢 tests/issues/issue-1083-modal-set-page.e2e.ts · 1 passed 17.6s
🟢 setPage called behind a native-stack modal lands on the requested page 17.6s
🟢 tests/issues/issue-1096-keyboard-shrink.e2e.ts · 1 passed 25.6s
🟢 keyboard avoidance does not shrink the page under the keyboard 25.6s
🟢 tests/issues/issue-1098-nested-pager.e2e.ts · 1 passed 18.5s
🟢 outer pager stays responsive after its page count changes around a nested pager 18.5s
🟢 tests/issues/issue-1142-search-bar-inset.e2e.ts · 1 passed 22.6s
🟢 FlatList inside the pager gets the search bar safe-area insets 22.6s
🟢 tests/material-top-bar.e2e.ts · 1 passed 25.4s
🟢 material top tabs survive a native-stack push and pop 25.4s
🟢 tests/nested-pager-view.e2e.ts · 1 passed 26.0s
🟢 nested horizontal and vertical pagers scroll independently 26.0s
🟢 tests/on-page-selected.e2e.ts · 1 passed 22.8s
🟢 onPageSelected fires an alert for every page change 22.8s
🟢 tests/scrollable-pager-view.e2e.ts · 1 passed 32.6s
🟢 pager inside a ScrollView keeps its page across vertical scrolls 32.6s
🟢 tests/smoke.e2e.ts · 1 passed 13.1s
🟢 horizontal pager pages with the panel buttons 13.1s
🟢 tests/tab-view-inside-scroll-view.e2e.ts · 1 passed 20.6s
🟢 TabView inside a ScrollView swipes tabs and scrolls the page 20.6s

e2e 0.18.0 · 8m 0s · ios · run artifacts

Comment thread package.json
"typescript": "tsc --noEmit",
"lint": "eslint \"**/*.{js,ts,tsx}\"",
"lint": "eslint .",
"format": "prettier --write \"**/*.{js,ts,tsx}\"",

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we consider using oxc? Or is this fine?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very little gain from oxc so I kept prettier

@krozniata
krozniata force-pushed the chore/eslint9-flat-config branch from ca10ef3 to 53bd783 Compare October 8, 2026 06:35
@troZee
troZee merged commit 9ebd8b5 into master Oct 8, 2026
7 of 9 checks passed
@troZee
troZee deleted the chore/eslint9-flat-config branch October 8, 2026 08:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants