fix(recurring): skip records the occurrence date, not the view's "today"#2146
Open
renatomen wants to merge 3 commits into
Open
fix(recurring): skip records the occurrence date, not the view's "today"#2146renatomen wants to merge 3 commits into
renatomen wants to merge 3 commits into
Conversation
Add a distinct optional occurrenceDate to the task context menu options, set by occurrence-addressed views (Calendar) and omitted by list/board producers, so occurrence-aware logic never infers occurrence-ness from the overloaded targetDate. Skip now passes the occurrenceDate when present (Calendar), otherwise no explicit date so the service's anchor-aware default resolves it - scheduled for scheduled-anchored recurrences (fixing the List/Kanban 'records today' bug) and today for completion-anchored recurrences (unchanged).
Adds the List/Kanban unskip-label path (occurrenceDate absent + resolved scheduled date already skipped), a due-only recurring case, and a showTaskContextMenu occurrenceDate-forwarding test; makes the completion-anchored assertion timezone-deterministic via getTodayString().
renatomen
force-pushed
the
feat/completion-occurrence-context-skip-fix
branch
from
July 21, 2026 11:18
cf4a267 to
6c17176
Compare
This was referenced Jul 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
For recurring tasks, "Skip this instance" (and the completion-status resolution it shares code with) recorded the action against the view's ambient
targetDate— which on list and board views is the view-wide "today", not the occurrence the user acted on. That records the skip/completion on the wrong date for scheduled-anchored recurrences.This makes the occurrence explicit instead of inferring it from the overloaded
targetDate:occurrenceDateto the task context-menu options. Occurrence-addressed producers (Calendar) set it to the clicked date; list/board producers omit it.occurrenceDatewhen present (Calendar), otherwise passes no explicit date so the service's existing anchor-aware default resolves it — the scheduled date for scheduled-anchored recurrences (fixing the List/Kanban "records today" bug), and today for completion-anchored recurrences (unchanged).Occurrence-aware logic reads
occurrenceDateand never infers occurrence-ness fromtargetDate.Testing
New unit suites
taskContextMenu.occurrenceContext.test.tsandtaskContextMenu.skip.test.tscover List/Kanban (records the scheduled occurrence, not today), Calendar (records the clicked occurrence), completion-anchored (still today), unskip, due-only, andshowTaskContextMenuforwarding — red-before-green verified on the skip fix.npm test, typecheck, and lint are green.Follow-up: #2147 (explicit completion-date control menu) builds directly on this bugfix.