Fixed chown of root owned files escaping the jenkins home - #2433
Merged
Conversation
Commit 6a8e329 caused chown to follow symlinks. The build machine runs tests from testmachine-chroot containing symlinks to root owned binaries like sudo. This caused sudo among other binaries to be owned by jenkins. Fixed this by telling chown to operate directly on symlinks (not follow them). And by telling find to skip the testmachine-chroot directory. Signed-off-by: Lars Erik Wik <lars.erik.wik@northern.tech>
Contributor
Author
|
@cf-bottom Jenkins please :) |
|
Sure, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14499/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14499/ |
victormlg
approved these changes
Aug 14, 2026
aleksandrychev
approved these changes
Aug 14, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Commit 6a8e329 caused chown to follow symlinks. The build machine runs
tests from testmachine-chroot containing symlinks to root owned binaries
like sudo. This caused sudo among other binaries to be owned by jenkins.
Fixed this by telling chown to operate directly on symlinks (not follow
them). And by telling find to skip the testmachine-chroot directory.
Signed-off-by: Lars Erik Wik lars.erik.wik@northern.tech