CFE-2140: Allowed modules to define lists with a trailing comma - #6271
Merged
Conversation
{ "a", } was rejected as malformed. Two commas in a row and a leading comma
still are.
The unit test disagreed with the acceptance test here, so seven single trailing
comma cases move from the must-fail table to the must-pass table.
Ticket: CFE-2140
Changelog: Title
Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com>
larsewi
approved these changes
Aug 6, 2026
Member
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14409/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14409/ |
Member
Author
|
@cf-bottom jenkins, please |
|
Alright, I triggered a build: Jenkins: https://ci.cfengine.com/job/pr-pipeline/14476/ Packages: http://buildcache.cfengine.com/packages/testing-pr/jenkins-pr-pipeline-14476/ |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Seven single trailing comma cases move from the unit test's must-fail table to must-pass, which is where the acceptance test has expected them since 2015.
Ticket: CFE-2140