Replaced per-check HSI inventory attributes with pass/fail lists - #156
Merged
Conversation
nickanderson
force-pushed
the
hsi-lists/master
branch
from
August 12, 2026 20:34
bbb8c52 to
ba930bb
Compare
|
Thank you for submitting a pull request! Maybe @craigcomstock can review this? |
craigcomstock
approved these changes
Aug 14, 2026
| # for use in compliance report conditions. | ||
| # - An slist of detailed results formatted "Name (HSI L<level>): | ||
| # <result> [PASS|FAIL]" for inventory drill-down. | ||
| # - "Firmware HSI failing" and "Firmware HSI passing", slists of |
Contributor
There was a problem hiding this comment.
It would be good to explain in the commit message and maybe in comments in the code why you use a pass/fail list (instead of the previous inventory attributes).
fwupd's security check set is hardware dependent, so one inventory attribute per check grew the fleet-wide attribute list with every distinct chipset while each host filled in only its own subset. Two slists keep the module at two stable attribute names regardless of the hardware, and carry the same information: a check in neither list is not applicable to that host. compliance-report-fwupd's per-check conditions are rewritten to match an item against "Firmware HSI failing", so the two modules must be released together. Changelog: title
Changelog: title
Changelog: title
nickanderson
force-pushed
the
hsi-lists/master
branch
from
August 14, 2026 13:27
3bf5611 to
94fe8fd
Compare
nickanderson
added a commit
to cfengine/build-index
that referenced
this pull request
Aug 14, 2026
inventory-fwupd 0.2.0, compliance-report-fwupd 0.2.0, manage-fwupd 0.1.2 inventory-fwupd replaces its per-check HSI inventory attributes with the "Firmware HSI failing" and "Firmware HSI passing" lists, and compliance-report-fwupd's conditions are rewritten to match against them, so both get a minor bump. manage-fwupd only changed its README. cfengine/modules#156
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the per-check HSI inventory attributes with two slists,
Firmware HSI failingandFirmware HSI passing, holdingL<level>: <name>items.Why: fwupd's check set is hardware dependent, so one inventory attribute per check grew the fleet-wide attribute list with every distinct chipset while each host filled in only its own subset. Two lists keep the module at two stable attribute names regardless of the hardware, and carry the same information — a check in neither list is not applicable to that host.
Breaking: compliance-report-fwupd's per-check conditions are rewritten in the same PR, so the two modules must be released together.