Skip to content

fix(examples): harden empty wallet accounts on connect - #8

Closed
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/harden-empty-wallet-accounts
Closed

fix(examples): harden empty wallet accounts on connect#8
kutluhaneth46 wants to merge 1 commit into
circlefin:masterfrom
kutluhaneth46:fix/harden-empty-wallet-accounts

Conversation

@kutluhaneth46

Copy link
Copy Markdown

Summary

  • Harden App Kit connect helpers so an empty account list cannot look connected
  • Prefer accounts returned by eth_requestAccounts, fall back to eth_accounts, and throw when no account is available so the catch path keeps action buttons disabled
  • Apply the same address-required rule for Solana connect in app-kit-bridge-solana
  • Cover send, swap, EVM bridge, and Solana bridge examples with focused helper tests

Complementary to #6 / #7 (retry-after-rejection). This PR targets the empty-account / false-connected path rather than permission rejection alone.

Test plan

  • cd app-kit-send && npm install && npm test
  • cd app-kit-swap && npm install && npm test
  • cd app-kit-bridge-evm && npm install && npm test
  • cd app-kit-bridge-solana && npm install && npm test
  • Manually reject/empty-account connect and confirm UI stays disconnected with retryable connect buttons

@kutluhaneth46
kutluhaneth46 force-pushed the fix/harden-empty-wallet-accounts branch from 81dc7aa to e2106c6 Compare September 6, 2026 14:16
@hjchen-circle

Copy link
Copy Markdown
Contributor

We acknowledge the issue raised in #6, but the scope of the proposed fix goes far beyond the original issue. Closing the PR. The issue is resolved in #9

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants