Added client sdk for Kotlin Multiplatform (Jvm + iOS)#5033
Open
Jessewb786 wants to merge 2 commits into
Open
Conversation
|
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Building on the original work of androidPoet, this provides a Kotlin Multiplatform client sdk.
It also adds the kotlin code generator to the CLI.
This is should be enough to close issue Add Kotlin Multiplatform SDK support #4821.
Expected complexity level and risk
This is a 5, but excepting the minor changes to the CLI, almost all changes are orthogonal to existing code, so there's very little chance of any form of regressions.
Testing
There is a suite of tests, all of which pass, and I'm using this implementation of what is intended to become a production ready Kotlin Multiplatform application.
I don't know if I've covered all corner cases, but it's so far covering everything I've needed from it.
That means, working on Spring backend services, Android and iOS.
Side note
I would love that this be extended so that the spacetime module itself can be written in Kotlin.