Pipeline the websocket send path#5051
Open
joshua-spacetime wants to merge 1 commit into
Open
Conversation
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
3 times, most recently
from
89fde61 to
fda28fc
Compare
joshua-spacetime
changed the base branch from
joshua/msync-offset-index
to
master
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
fda28fc to
388f0d8
Compare
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
388f0d8 to
c5c3d1a
Compare
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
c5c3d1a to
0972b81
Compare
kim
approved these changes
May 18, 2026
| fn drain_pending(&mut self, buf: &mut Vec<OutboundMessage>, max: usize) -> usize { | ||
| let n = self.pending.len().min(max); | ||
| buf.reserve(n); | ||
| for update in self.pending.drain(..n) { |
Contributor
There was a problem hiding this comment.
nit: I think extend() might be slightly more efficient
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In keeping with the "pipeline everything" ethos, I've replaced
recvwithrecv_manyonClientConnectionReceiverso that a client connection's websocket send path works on a batch of messages at a time, if possible.API and ABI breaking changes
None
Expected complexity level and risk
1.5
Testing
Refactor