Batch websocket responses using the v3 protocol#5061
Merged
Conversation
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
c5c3d1a to
0972b81
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
31e54ca to
fa60dfa
Compare
joshua-spacetime
force-pushed
the
joshua/message-pipelining
branch
from
0972b81 to
2926736
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
fa60dfa to
7f11e8b
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
2 times, most recently
from
d6cc30a to
abcec19
Compare
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
d318465 to
af242c1
Compare
Accumulate up to 512KiB in single v3 message
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
af242c1 to
b8d357a
Compare
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
Fallback to v1 on protocol negotiation
joshua-spacetime
force-pushed
the
joshua/batch-server-side-sends
branch
from
8d8a1f0 to
8eb0f19
Compare
bfops
approved these changes
May 19, 2026
Collaborator
bfops
left a comment
bfops
left a comment
There was a problem hiding this comment.
My code-owned changes LGTM (in that they're mostly Spacetime-meat code that I don't have any strong opinions about).
I would like to have at least a manual test of the old-server-compatibility flow.
Contributor
Author
|
@gefjon feel free to ignore the |
gefjon
approved these changes
May 20, 2026
Contributor
|
I did, indeed, ignore the |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
In keeping with the "pipeline everything" approach of SpacetimeDB, this patch serializes multiple client updates in a single websocket message using the v3 protocol.
API and ABI breaking changes
None.
spacetime subscribewas updated to use the v3 websocket api, but it falls back to v1 if protocol negotiation fails.Expected complexity level and risk
2
Testing
This patch updates
spacetime subscribeto use the v3 websocket protocol by default in order to get adequate coverage via the smoketests.