Add required ci check for keynote-2 benchmark#5078
Open
joshua-spacetime wants to merge 1 commit into
Open
Conversation
joshua-spacetime
requested review from
bfops,
cloutiertyler and
jdetter
as code owners
joshua-spacetime
changed the title
keynote-2 benchmark
joshua-spacetime
force-pushed
the
joshua/keynote-ci-check
branch
from
9b8e2ab to
ad299df
Compare
joshua-spacetime
changed the base branch from
joshua/batch-server-side-sends
to
master
joshua-spacetime
force-pushed
the
joshua/keynote-ci-check
branch
3 times, most recently
from
9588d67 to
e814040
Compare
joshua-spacetime
force-pushed
the
joshua/keynote-ci-check
branch
from
e814040 to
f83797b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
Adds a new required ci check for keynote-2 benchmark regressions. The test runs for 60s and fails if throughput < 300K TPS.
Note, this check will be flaky as long as it's running concurrently with other CI jobs. It may need a dedicated runner/host machine. Although it may be sufficient to only schedule one runner/VM to a single host machine at a time. I'll need to sync with @jdetter to determine the best way forward here.
API and ABI breaking changes
N/A
Expected complexity level and risk
2
Mainly copy-paste from the other CI workflows.
Testing
N/A