Move duplicate os-morphing code to core#453
Merged
petrutlucian94 merged 6 commits intoJun 10, 2026
Merged
Conversation
petrutlucian94
force-pushed
the
move_common_osmorphing
branch
from
05ace55 to
ce717a1
Compare
petrutlucian94
force-pushed
the
move_common_osmorphing
branch
2 times, most recently
from
72f04e4 to
76c69ac
Compare
petrutlucian94
changed the title
claudiubelu
reviewed
Jun 10, 2026
The virtio installation helper is currently duplicated across all the providers. We'll move it to Coriolis core instead.
The code that enables Debian 7 backports is duplicated across Coriolis providers. So is the method that enables an UEFI fallback bootloader. We'll go ahead and move them to Coriolis core. However, the UEFI fallback bootloader won't be enabled by default since providers that preserve the firmware type shouldn't actually need it.
The helper that updates the initramfs on Ubuntu is duplicated by multiple providers, we'll move it to Coriolis core.
petrutlucian94
force-pushed
the
move_common_osmorphing
branch
from
76c69ac to
a28e65f
Compare
claudiubelu
approved these changes
Jun 10, 2026
Dany9966
reviewed
Jun 10, 2026
As per the PR feedback, we'll move "_run_update_initramfs" to the Debian os-morphing tools and call it by default during "post_packages_install".
A previous commit added the helper but expected the providers to call it. There's no reason why we can't do it as part of "post_packages_install" by default.
Container images such as the ones used by the integration tests do not include the "linux-version" binary. We'll catch this and log a warning.
petrutlucian94
force-pushed
the
move_common_osmorphing
branch
from
aaa29d8 to
fd1a0f7
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
There's a significant amount of os-morphing code duplication among Coriolis providers.
This PR moves the following to Coriolis core: