[AIENG-504] added never failing tests and longest tests commands#1330
Open
sandeepbarnwal wants to merge 3 commits into
Open
[AIENG-504] added never failing tests and longest tests commands#1330sandeepbarnwal wants to merge 3 commits into
sandeepbarnwal wants to merge 3 commits into
Conversation
Konboi
reviewed
Jun 19, 2026
| from ...utils.typer_types import DateTimeWithTimezone, parse_datetime_with_timezone | ||
|
|
||
|
|
||
| def validate_iso_week(value: str) -> str: |
Contributor
There was a problem hiding this comment.
Defining this method in each method is redundant, so please define a validate_iso_week method in util/typer_types.py, then import and use it.
| if weeks: | ||
| params["weeks"] = str(weeks) | ||
| if from_date: | ||
| params["from"] = str(from_date) |
Contributor
There was a problem hiding this comment.
The way from_date and to_date are parsed is different from the flaky test implementation (flaky test) , so please align it with the flaky test behavior.
Contributor
Author
There was a problem hiding this comment.
Oh, It got updated after my PR. Let me align it.
| except Exception as e: | ||
| client.print_exception_and_recover( | ||
| e, | ||
| "Warning: failed to retrieve longes running tests from server" |
Contributor
There was a problem hiding this comment.
Suggested change
| "Warning: failed to retrieve longes running tests from server" | |
| "Warning: failed to retrieve longest running tests from server" |
| )] = None, | ||
| test_path: Annotated[str | None, typer.Option( | ||
| "--test-path", | ||
| help="Test path filter (e.g., 'com.example.MyTest')", |
Contributor
There was a problem hiding this comment.
Let’s align the test path in the help message with the flaky test implementation.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
Testing
smart-tests view longest-testsandsmart-tests view never-failing-testsmanually