codemode: client-side tool calls via durable pause/resolve#1905
Draft
mattzcarey wants to merge 2 commits into
Draft
codemode: client-side tool calls via durable pause/resolve#1905mattzcarey wants to merge 2 commits into
mattzcarey wants to merge 2 commits into
Conversation
🦋 Changeset detectedLatest commit: ef24456 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
7daa1af to
ef24456
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1735.
Lets generated code call client-side (execute-less) tools by generalizing the durable approval machinery into value-carrying resolution: a client tool call pauses the run as a pending log entry marked
resolution: "client"; the client supplies the result via a newresolve(), which records it as applied and resumes via the existing replay — so the model just writesconst tz = await tools.getUserTimezone({})and the run durably parks until the client answers.What changed
ToolAnnotations.resolution?: "approval" | "client"— both imply a pause; approval stays the default for gated calls. Carried throughToolLogEntryandPendingActionso approval UIs can distinguish "approve/deny" from "compute and return".CodemodeRuntime.resolve(executionId, seq, result)— mirrorsreject(): only a pending entry on a paused run; stores the client result (same size guard) and flips it to applied.decide()will never execute a client-pending entry server-side —approve()on such a run just re-pauses; once resolved, ordinary replay serves the value with the usual divergence check.resolveCodemode()/handle.resolve({executionId, seq, result})— records the result then reuses the resume path; stale/duplicate resolves return an error outcome, not a throw.ToolSetConnectoropt-inclientTools: "pause"(default "skip" preserves today's skip-and-warn): execute-less tools are exposed in the sandbox +getTypeScriptTypes(), annotated client-resolved, with a throwing server-side execute as a safety net.Notes / deferred
expirePausedalready covers a client that never answers.@callable resolveExecutionon the agent), reusing the existingonToolCall-style handler.Draft — API surface up for discussion.