rename configureElicitationHandler to configureElicitationHandlers#1917
Conversation
The method takes a { form, url } group and every related name is already
plural (MCPClientElicitationHandlers, the elicitationHandlers connection
option); the manager and connection methods were the singular outliers.
The API is unreleased, so the rename ships in the same release that
introduces it.
|
| Name | Type |
|---|---|
| agents | Patch |
| @cloudflare/agent-think | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
There was a problem hiding this comment.
Devin Review found 1 potential issue.
⚠️ 1 issue in files not directly in the diff
⚠️ Stray npm lockfile left behind in a pnpm-only workspace (examples/mcp-client/package-lock.json:1)
An npm lockfile is accidentally committed (examples/mcp-client/package-lock.json) despite the repo using pnpm exclusively, so contributors may see conflicting dependency resolution or confusion about which package manager to use.
Impact: The 1820-line generated file clutters the repo and contradicts the pnpm-only convention.
The cleanup commit missed one file
Commit ba966099 ("remove stray package-lock artifacts") removed examples/mcp-server/package-lock.json and examples/tictactoe/package-lock.json but missed examples/mcp-client/package-lock.json, which was added in the preceding rename commit 4160f4d5. The repo root AGENTS.md states the project uses pnpm workspaces with pnpm-lock.yaml as the sole lockfile.
View 1 additional finding in Devin Review.
agents
@cloudflare/ai-chat
@cloudflare/codemode
create-think
hono-agents
@cloudflare/shell
@cloudflare/think
@cloudflare/voice
@cloudflare/worker-bundler
commit: |
1 participant
The method takes a
{ form, url }group and every related name is already plural (MCPClientElicitationHandlers,MCPElicitationHandlers, theelicitationHandlersconnection option, the internalscopedElicitationHandlers) — the manager and connection methods were the singular outliers.Follow-up to #1911. The API is unreleased (pending Version Packages), so the rename ships in the same release that introduces it — no compatibility alias kept. Mechanical rename across src, tests, conformance, examples, docs, and the existing (unreleased) changeset texts; no behavior change.