test(runtime-sdk): report a failing WebSocket test instead of hanging - #238
Merged
ryanking13 merged 1 commit intoSep 1, 2026
Merged
Conversation
test_client_close_reaches_app_as_disconnect opened its socket by hand, so a failure before its ws.close() left the app awaiting receive() and the worker invocation never completed, reaching the CI job limit instead of reporting the assertion. Drive it through _ws_session, which closes the socket however the test ends. Injecting the same deliberate failure before the close, the run went from timing out with no output to failing in 12s.
ryanking13
approved these changes
Aug 31, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current impl of
test_client_close_reaches_app_as_disconnectcan hang when something fails beforews.close()as it leave the app awaitingreceive()and the worker invocation never completed.This PR fixes it by using the
_ws_session()context to close the socket however the test ends.