Repository navigation
Tidy up broker HTTP client request logging - #5537
Merged
Merged
Conversation
Make broker request body logging consistent with response logging
jochenehret
approved these changes
Oct 13, 2026
ari-wg-gitbot
added a commit
to cloudfoundry/capi-release
that referenced
this pull request
Oct 13, 2026
Changes in cloud_controller_ng:
- Tidy up broker HTTP client request logging
PR: cloudfoundry/cloud_controller_ng#5537
Author: Katharina Przybill <30441792+kathap@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Make broker request body logging consistent with response logging
A short explanation of the proposed change:
Updates the service broker HTTP client so the outbound request body is rendered through a small helper before being written to the debug log, mirroring how the response body is already handled. Adds unit coverage for the request-body logging path.
An explanation of the use cases your change solves
The broker HTTP client logs requests and responses at debug level. This renders the request body through the same helper the response body already uses, so both are logged consistently.
I have reviewed the contributing guide
I have viewed, signed, and submitted the Contributor License Agreement
I have made this pull request to the
mainbranchI have run all the unit tests using
bundle exec rakeI have run CF Acceptance Tests