establishing compatibility with Apple architecture - #560
Merged
Conversation
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The changes are narrowly scoped, consistent across configs/scripts/tests, and the Maven exclusions are targeted to the documented Apple Silicon failure mode.
Pull request overview
This PR updates the default “petclinic” base image and test/build dependencies to improve compatibility when running the project on Apple Silicon (arm64), avoiding Alpine/legacy native library issues.
Changes:
- Switch
petclinicimage references fromeclipse-temurin:17-jre-alpinetoeclipse-temurin:17-jreacross example application YAMLs, tests, and dev registry scripts. - Exclude
groovy-groovyshandjlinefrom the test-scopedgroovy-alldependency to prevent Apple Silicon failures caused by an incompatible bundled native Jansi library. - Minor formatting/indentation cleanup in
ArgoCDTest.groovy.
File summaries
| File | Description |
|---|---|
| src/test/groovy/com/cloudogu/gitops/tools/core/argocd/ArgoCDTest.groovy | Updates the test config’s petclinic image reference and normalizes indentation in a constructor call. |
| src/main/resources/application-operator-full.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| src/main/resources/application-operator-content-examples.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| src/main/resources/application-keycloak.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| src/main/resources/application-full.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| src/main/resources/application-full-prefix.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| src/main/resources/application-content-examples.yaml | Updates example petclinic image to a non-Alpine Temurin JRE tag. |
| scripts/dev/prepare_two_registries.sh | Updates the locally mirrored petclinic image tag used in the generated config snippet. |
| scripts/dev/mirror_images_to_registry.sh | Updates the mirrored Temurin image tag and corresponding skopeo copy destinations. |
| pom.xml | Adds test-scope exclusions to avoid Apple Silicon failures caused by groovy-groovysh/jline pulling in incompatible native libs. |
Review details
- Files reviewed: 10/10 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
mdroll
self-requested a review
September 7, 2026 07:21
mdroll
changed the title
mdroll
approved these changes
Sep 7, 2026
mdroll
left a comment
mdroll
left a comment
Contributor
There was a problem hiding this comment.
lgtm:
Tested normal unit test run
Tested full profile run in cluster
Tested operator-full
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR updates the default “petclinic” base image and test/build dependencies to improve compatibility when running the project on Apple Silicon (arm64), avoiding Alpine/legacy native library issues.
Changes:
Switch petclinic image references from eclipse-temurin:17-jre-alpine to eclipse-temurin:17-jre across example application YAMLs, tests, and dev registry scripts.
Exclude groovy-groovysh and jline from the test-scoped groovy-all dependency to prevent Apple Silicon failures caused by an incompatible bundled native Jansi library.
Minor formatting/indentation cleanup in ArgoCDTest.groovy.