Skip to content

fix: remove trailing newline after last rendered line#139

Open
Harsh-Anand-Singh wants to merge 1 commit into
mainfrom
fix/codeview-trailing-newline
Open

fix: remove trailing newline after last rendered line#139
Harsh-Anand-Singh wants to merge 1 commit into
mainfrom
fix/codeview-trailing-newline

Conversation

@Harsh-Anand-Singh
Copy link
Copy Markdown
Member

Description

Removes a stray trailing \n that CodeView was emitting after the last rendered line in both the plain-text and syntax-highlighted render paths. Output now equals input verbatim, and user-supplied trailing newlines are preserved.

Related links, issue #, if available: n/a

How has this been tested?

  • Added unit tests asserting exact textContent for single-line, multi-line, trailing-newline, and highlighted inputs.
  • All existing unit tests pass.

@codecov
Copy link
Copy Markdown

codecov Bot commented May 15, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 99.29%. Comparing base (d6a888c) to head (fbbb507).

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #139      +/-   ##
==========================================
- Coverage   99.64%   99.29%   -0.36%     
==========================================
  Files          29       29              
  Lines         284      284              
  Branches       33       35       +2     
==========================================
- Hits          283      282       -1     
  Misses          1        1              
- Partials        0        1       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@Harsh-Anand-Singh Harsh-Anand-Singh force-pushed the fix/codeview-trailing-newline branch from bb47687 to fbbb507 Compare May 15, 2026 15:50
@Harsh-Anand-Singh Harsh-Anand-Singh changed the title fix(code-view): remove trailing newline after last line fix: remove trailing newline after last rendered line May 15, 2026
@Harsh-Anand-Singh Harsh-Anand-Singh requested a review from jperals May 15, 2026 16:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant