Repository navigation
test(sweep): pin the no-catch-up recovery of delayed reviewers after missed schedule runs - #567
hivecommons-hive[bot] wants to merge 1 commit into
Conversation
…missed schedule runs After the schedule misses runs for longer than sweep.lookback, a pull request whose review clock expired before now - delay - lookback is neither listed, read nor requested by the delayed-reviewers step, and a longer sweep.lookback is what recovers it. Pinned in a unit suite (__tests__/cronJobTest/sweepDelayOutage.test.ts) and against dist/index.js (__tests__/bundle/blunderbussDelayOutage.test.ts); the blunderbuss.delay paragraph of docs/configuration.md now records the expectation. Refs #554 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
|
Important Held for human review by the hive's ACMM level gate. This PR was opened by the "quality" agent while Hive policy required a human checkpoint for that agent. Agent PRs are held at ACMM L3–L5; an Hive will keep the |
|
/kind cleanup 🐝 Hive Agent: — hive: agent=quality backend=copilot model=claude-fable-5.1 copilot=1.0.88 |
|
Consolidated into #589 (commit cherry-picked unchanged, author and DCO sign-off preserved). |
…solidates #555, #558, #559, #561, #562, #564-#567) (#589) * test: cover paginated OWNERS and review timelines Exercise approval authorization, automatic reviewer selection, and delayed reviewer timing across page boundaries. Hive-Run: #554 Hive-Plan: P2 cross-request contracts Hive-Spec: issue-554#P2-cross-request-contracts Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com> * test(sweep): pin the inclusive due-window bounds and the timeline-read failure of delayed reviewers Add four cases to the 'sweep with blunderbuss.delay' block of __tests__/cronJobTest/sweep.test.ts, exercising requestReviewersIfDue's window checks at the exact instants and 1 ms past them, for created_at and for the last ready_for_review alike, and the failure path when the timeline read itself fails. Each boundary case fails on a one-character mutant of sweep.ts that the existing suite accepted: '>' to '>=' on the created_at early return, '<' to '<=' or '>' to '>=' on the shifted-window check. The failure case covers the catch in lastReadyForReview (previously unit-uncovered) and pins that the error is reported as a blunderbuss failure of that pull request while the other pull requests still get their reviewers. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin that a second delayed sweep leaves the first run's requested reviewers alone The delayed-blunderbuss bundle suite modelled a pull that already had reviewers only as a static fixture. This drives dist/index.js through two successive sweeps against a fake whose pull list reflects the reviewer request the first sweep made, and asserts the second run neither re-reads the timeline or reviews nor requests reviewers again. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files Both suites left the false arm of the branchHasOwners guard ahead of requestReviewersIfDue in src/cronJobs/sweep.ts with zero hits: every delayed-blunderbuss case served an OWNERS file on master. Add one unit case and one dist/index.js scenario, each in its own file, that configure blunderbuss.delay, serve an empty master tree and a due pull request, and assert the tree is probed once while the timeline, reviews and requested_reviewers endpoints are never touched. Both fail when the guard is replaced by `|| true`. Fixes #560 Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin the reviewer-key fallbacks of delayed blunderbuss on a bare pull listing (sweep.ts:208) requestReviewersIfDue reads requested_reviewers ?? [] and requested_teams ?? [] off the pull list entry, but no unit or bundle test listed a delayed-only pull request without those keys, leaving both fallback arms unreached in coverage/ and coverage-e2e/. Serve a due pull with the keys removed on both harnesses and assert reviewers are still requested. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(owners): pin the fail-closed OWNERS group read when a later members page cannot be fetched (owners.ts:153-162) Let the real octokit paginator walk a team's Link headers instead of the stubbed paginate the existing group tests use. A page-one member is an approver once every page is read; when page two returns 500 the group contributes nobody, the run warns once naming the team, and the page-one member is denied without a fallback to organization membership. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85) Adds __tests__/cronJobTest/sweepDelayFailures.test.ts: two due delayed-only pull requests on a base branch with OWNERS, where one fails. A 500 on the reviews read is recorded as that pull request's `blunderbuss:` failure while the other still gets its reviewer request; a non-Error rejection of requestOwnersReviewers is stringified the same way. Before: coverage/lcov.info BRDA:85,5,0,0 / BRDA:85,5,1,0 (neither arm hit by the unit suite). After: both 1; sweep.ts branches 92.3 -> 94.87 %. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin the ignore_drafts=false arm of delayed reviewers (sweep.ts:218) With blunderbuss.delay set and ignore_drafts: false, requestReviewersIfDue must not skip drafts and must time every pull request from created_at alone, never reading the timeline. The unit suite only ever ran the delayed sweep with the default ignore_drafts: true, so that arm was reached by the bundle suite alone. Pins it in its own file so it does not collide with the pending edits to the delay block of sweep.test.ts. Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(sweep): pin the no-catch-up recovery of delayed reviewers after missed schedule runs After the schedule misses runs for longer than sweep.lookback, a pull request whose review clock expired before now - delay - lookback is neither listed, read nor requested by the delayed-reviewers step, and a longer sweep.lookback is what recovers it. Pinned in a unit suite (__tests__/cronJobTest/sweepDelayOutage.test.ts) and against dist/index.js (__tests__/bundle/blunderbussDelayOutage.test.ts); the blunderbuss.delay paragraph of docs/configuration.md now records the expectation. Refs #554 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> * test(harness): fail tide and sweep unit tests on unserved requests Completes the #571 wiring that was deferred while #557 and #558 occupied these files: both servers now answer the merge-queue read with noMergeQueue and assert at the end of each test that no request went unserved; sweep's OWNERS scenarios serve the base-branch tip instead of running through the 'could not read the tip' fallback. Refs #570 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org> --------- Signed-off-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Signed-off-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com> Signed-off-by: Bob Killen <bkillen@linuxfoundation.org> Co-authored-by: mrbobbytables <mrbobbytables@users.noreply.github.com> Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: quality <280983584+hivecommons-hive[bot]@users.noreply.github.com>
Test Improvement
Pins the Scheduling outage recovery item of #554 ("explicitly document and test the chosen recovery expectation when missed runs exceed the lookback window. The current implementation intentionally excludes sufficiently old PRs; do not silently change this into unlimited catch-up"). No source change.
Files/functions claimed (all new or docs-only, disjoint from every open hold-gated PR):
__tests__/cronJobTest/sweepDelayOutage.test.ts(new) — unit,sweep→recentlyUpdatedPulls(…, due.from)insrc/cronJobs/sweep.ts__tests__/bundle/blunderbussDelayOutage.test.ts(new) — the same contract throughdist/index.jsdocs/configuration.md, theblunderbuss.delayparagraph — records the expectationDisjoint from #555 (
fakeGithub.ts,ownersGroups/blunderbussDelaybundle tests), #558 (sweep.test.tsdue-window bounds: a PR 1 ms beforedue.fromthat is still listed), #559 (blunderbussDelay.test.ts), #561/#562/#565/#566 (their ownsweepDelay*/blunderbussDelay*files), #563 (config.ts) and #556 (contributing.md).delay: 1h)lookback(1h), window[now−2h, now−1h]page=1); no request at all names #2 (/pulls/2*,/issues/2*),sweep: 1 more checked for delayed reviewerssweep.lookback: 2h, window[now−3h, now−1h]sweep: 1 candidate updated sinceMutant check (per #554's "justify by mutation, not percentage"): changing the list bound in
sweep()fromdue.fromtonew Date(0)(unbounded catch-up) fails the first unit case (expected [1, 2] to deeply equal [1], the timeline reads) while the existing 42sweep.test.tscases and the bundleblunderbussDelaycases accept it — the delayed block there always serves a short single page, so the listing bound was unpinned. The cases add no new lines or branches by design.Docs: the
blunderbuss.delayparagraph now states that the sweep does not catch up pastnow − delay − lookback, thatlookback(capped at 24h) is the knob for riding out missed slots, and that/auto-ccor a manual request covers a pull request missed that way.Coverage evidence
npm run test:coverageonmain@e3119ad: 2330 tests, 99.92 % lines / 99.35 % branches;sweep.ts98.33 / 92.3, uncovered85,244(both claimed by test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85) #565/test(sweep): pin the inclusive due-window bounds and the timeline-read failure of delayed reviewers #558). The four other reported lines (close.ts:39,reopen.ts:36,approve.ts:504,auth.ts:220) are the documented v8 negative-count artifact (docs/contributing.md), not gaps.npm run test:coverage:e2eonmain@e3119ad: 528 tests, 100 % lines / 99.46 % branches;sweep.ts100 / 94.87, uncovered80-85,208(claimed by test(sweep): pin the delayed-reviewers OWNERS guard on a base branch without OWNERS files (sweep.ts:80) #561/test(sweep): pin the delayed-reviewers catch of sweep in its Error and String(e) arms (sweep.ts:85) #565/test(sweep): pin the reviewer-key fallbacks of delayed blunderbuss on a bare pull listing (sweep.ts:208) #562).Verification
npx vitest run __tests__/cronJobTest/sweepDelayOutage.test.ts __tests__/bundle/blunderbussDelayOutage.test.ts __tests__/configurationDocs.test.ts __tests__/docsYamlExamples.test.ts— 4 files passednpx eslinton the three changed files — cleanRelated Issue
Refs #554 — ticks only the "Scheduling outage recovery" box of the P2 cross-request section. The P1 CI-enforcement, release and harness sections and the other P2 boxes stay open there (tracked by #555/#557/#558/#559/#564); a single test PR must not close the tracker.
Filed by quality agent (hold-gated mode). Human review required.
— hive: agent=quality backend=copilot model=claude-fable-5.1 requested_by=@mrbobbytables