test(harness): fail a unit test on any msw request no handler served; serve the merge-queue state and base-branch tip the exposed tests were falling back from

__tests__/cronJobTest/handleCronJob.test.ts

@@ -9,7 +9,8 @@ import pullReqOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
 
 import * as utils from '../testUtils'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/cronJobTest/labelSync.test.ts

@@ -16,7 +16,8 @@ import * as utils from '../testUtils'
 // non-Error fallback of a refused write is only reachable through a stub
 vi.mock('../../src/utils/octokit', { spy: true })
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/cronJobTest/lgtm.test.ts

@@ -29,6 +29,7 @@ function servePullsByNumber(prs: typeof listPullReqs) {
 }
 
 const server = setupServer(
+  utils.noMergeQueue,
   ...utils.noOrgOrRepoConfigExcept(),
   // the gate's default depends on whether the default branch has OWNERS files; none here unless a test serves a tree
   utils.defaultBranchTree(),
@@ -61,6 +62,7 @@ const server = setupServer(
     },
   ),
 )
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/approve.test.ts

@@ -14,7 +14,8 @@ import pullReqListReviews from '../fixtures/pullReq/pullReqListReviews.json'
 import * as utils from '../testUtils'
 import { baseBranch, blobSha, changedFiles, filesHandler, prCommentEvent, prHandlers, pullHandler, repo, treeHandlers } from '../utils/ownersFixtures'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/approveMilestoneErrorPaths.test.ts

@@ -16,6 +16,7 @@ import * as utils from '../testUtils'
 vi.mock('../../src/utils/auth', { spy: true })
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/assign.test.ts

@@ -11,6 +11,7 @@ import issueListComments from '../fixtures/issues/assign/issueListComments.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/cc.test.ts

@@ -11,6 +11,7 @@ import pullReviewRequested from '../fixtures/pullReq/pullReviewRequested.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/close.test.ts

@@ -12,6 +12,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/commentWithoutBody.test.ts

@@ -7,6 +7,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 let calls: string[]
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 beforeEach(() => {

__tests__/issueCommentTest/errorPaths.test.ts

@@ -20,6 +20,7 @@ import * as utils from '../testUtils'
 vi.mock('../../src/utils/auth', { spy: true })
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/handleIssueComment.test.ts

@@ -22,6 +22,7 @@ import * as utils from '../testUtils'
 import { prCommentEvent, prHandlers, pullHandler, repo } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 
 // the dispatch tests below mock every command; the sweep that follows a command is stubbed the same way

__tests__/issueCommentTest/lock.test.ts

@@ -10,6 +10,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/meow.test.ts

@@ -14,6 +14,7 @@ import * as utils from '../testUtils'
 const catApi = 'https://api.thecatapi.com/v1/images/search'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 
 // msw answers every mocked request without resolving its host, so the only
 // way a unit test reaches dns is a socket the interceptor passed through

__tests__/issueCommentTest/milestone.test.ts

@@ -11,6 +11,7 @@ import repoMilestones from '../fixtures/milestones/repoListMilestones.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/reopen.test.ts

@@ -12,6 +12,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/retitle.test.ts

@@ -10,6 +10,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/reviewAuthorization.test.ts

@@ -13,6 +13,7 @@ import * as utils from '../testUtils'
 import { prCommentEvent, prHandlers } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/issueCommentTest/trigger.test.ts

@@ -13,7 +13,8 @@ import prOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
 import * as utils from '../testUtils'
 import { prCommentEvent, prHandlers, repo } from '../utils/ownersFixtures'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => {
   server.resetHandlers()
@@ -670,7 +671,7 @@ describe('/test', () => {
 
   it('refuses an outsider', async () => {
     const reply = new utils.ObserveRequest()
-    server.use(...outsiderAuth(), http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)))
+    server.use(...outsiderAuth(), http.post(`${repo}/issues/1/comments`, utils.mockResponse(201, {}, reply)), ...utils.noOrgOrRepoConfigExcept())
     const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})
     vi.spyOn(core, 'error').mockImplementation(() => {})
 

__tests__/issueCommentTest/unassign.test.ts

@@ -11,6 +11,7 @@ import issueUnassignedResp from '../fixtures/issues/unassign/issueUnassignedResp
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issueCommentTest/uncc.test.ts

@@ -10,6 +10,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/issuesTest/handleIssues.test.ts

@@ -8,6 +8,7 @@ import issuesLabeledEvent from '../fixtures/issues/issuesLabeledEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/area.test.ts

@@ -11,6 +11,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/authorization.test.ts

@@ -11,6 +11,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/label/dynamic.test.ts

@@ -11,6 +11,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/errorPaths.test.ts

@@ -19,6 +19,7 @@ import * as utils from '../testUtils'
 vi.mock('../../src/utils/auth', { spy: true })
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/help.test.ts

@@ -10,6 +10,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/hold.test.ts

@@ -12,6 +12,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer(...utils.noOrgOrRepoConfigExcept())
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/kind.test.ts

@@ -11,6 +11,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/label.test.ts

@@ -13,6 +13,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/lgtm.test.ts

@@ -20,7 +20,8 @@ import { prCommentEvent, prHandlers } from '../utils/ownersFixtures'
 // /lgtm is only reachable when the binding itself rejects with a bare value
 vi.mock('../../src/plugins/lgtmBinding', { spy: true })
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/lifecycle.test.ts

@@ -12,6 +12,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/prefixed.test.ts

@@ -8,6 +8,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/label/priority.test.ts

@@ -11,6 +11,7 @@ import labelFileContents from '../fixtures/labels/labelFileContentsResp.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/label/remove.test.ts

@@ -10,6 +10,7 @@ import issueCommentEvent from '../fixtures/issues/issueCommentEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/missingNumberMessage.test.ts

@@ -27,6 +27,7 @@ import * as utils from './testUtils'
 
 // every request is unexpected: the handlers must refuse before calling the API
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() =>
   server.listen(utils.failOnUnhandledRequest),
 )

__tests__/plugins/approveErrorPaths.test.ts

@@ -13,6 +13,7 @@ import * as utils from '../testUtils'
 import { prHandlers, repo } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/approveEvents.test.ts

@@ -13,7 +13,8 @@ import reviewSubmittedEvent from '../fixtures/pullReq/pullReqReviewSubmittedEven
 import * as utils from '../testUtils'
 import { prHandlers, repo } from '../utils/ownersFixtures'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/approveReview.test.ts

@@ -17,7 +17,8 @@ import reviewSubmittedEvent from '../fixtures/pullReq/pullReqReviewSubmittedEven
 import * as utils from '../testUtils'
 import { prHandlers, pullBody, repo } from '../utils/ownersFixtures'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/blunderbuss.test.ts

@@ -15,6 +15,7 @@ import * as utils from '../testUtils'
 import { baseSha, changedFiles, filesHandler, prCommentEvent, repo, treeHandlers } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/lgtmBinding.test.ts

@@ -12,6 +12,7 @@ import pullReqOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/ownersLabel.test.ts

@@ -10,6 +10,7 @@ import * as utils from '../testUtils'
 import { baseSha, changedFiles, filesHandler, prHandlers, pullHandler, repo, treeHandlers } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())
@@ -216,6 +217,8 @@ describe('ownersLabel', () => {
     const setFailed = vi.spyOn(core, 'setFailed').mockImplementation(() => {})
     server.use(
       ...utils.noOrgOrRepoConfigExcept(),
+      // the approve handler runs on opened too; an OWNERS-less default branch keeps it out of this test
+      utils.defaultBranchTree(),
       http.get(`${repo}/pulls/1`, utils.mockResponse(500, { message: 'boom' })),
     )
 

__tests__/plugins/pluginErrorPaths.test.ts

@@ -13,6 +13,7 @@ import * as utils from '../testUtils'
 import { prHandlers } from '../utils/ownersFixtures'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 beforeEach(() => utils.setupActionsEnv())
 afterEach(() => server.resetHandlers())

__tests__/plugins/requireMatchingLabel.test.ts

@@ -19,7 +19,8 @@ import pullReqOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
 import * as utils from '../testUtils'
 import { pullHandler } from '../utils/ownersFixtures'
 
-const server = setupServer()
+const server = setupServer(utils.noMergeQueue)
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())

__tests__/plugins/tideMergeQueue.test.ts

@@ -11,6 +11,7 @@ import pullReqOpenedEvent from '../fixtures/pullReq/pullReqOpenedEvent.json'
 import * as utils from '../testUtils'
 
 const server = setupServer()
+utils.failTestOnUnhandledRequests(server)
 beforeAll(() => server.listen(utils.failOnUnhandledRequest))
 afterEach(() => server.resetHandlers())
 afterAll(() => server.close())