chore: translate all Korean text to English - #613
Merged
Conversation
Localize the risky-main-model warning banner (title and body) to English and update the TUI test assertion to match.
Swap Korean sample data for equivalent Chinese/Japanese wide characters in the terminal width, UTF-8 reassembly, stdin-paste, width-cache, overlay, and LaTeX-unicode tests so the repo contains no Hangul while preserving the wide-character and byte-reassembly behavior these tests exercise.
Localize the caret eval renderer fixture titles, sample code, output text, and temp paths to English, and update the corresponding width assertions. Also swap the Korean sample in the overlay example for a CJK mix.
Localize the Tistory reader-mode HTML fixtures and assertions, the OpenAI foreign-signature sample thinking text, the streaming-reveal CJK samples, the UTF-8-boundary projection fixture, compaction filler, footer wide-name samples, and the todo-arg-correction/normalize task items to English.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes all Hangul (Korean script) from the repository's tracked source and test files by translating to English, keeping every test and the repo typecheck green.
This is a translation-only pass — no behavior, logic, identifier, key, or semantic change.
npm run checkandnpm testboth pass; a final repo-widerg -n "[가-힣]"returns zero matches across tracked files.Scope decision (CJK width / IME fixtures)
A subset of tests use Korean as character data under test (wide-character width computation, UTF-8 byte reassembly across buffers, IME paste framing, LaTeX-unicode conversion). Translating those samples to English would narrow the characters and silently destroy the behavior those tests exercise. For those fixtures only, Hangul was replaced with equivalent wide CJK (Chinese/Japanese) characters so the intended behavior is preserved and the post-condition (no Hangul) holds. Prose, UI strings, comments, and realistic sample content were translated to English.
Commits
fix(coding-agent)translate risky-model warning text to Englishtest(tui)replace Hangul samples with CJK wide chars in width/IME teststest(senpi-codemode)translate eval render fixtures to Englishtest(coding-agent)translate remaining fixtures to EnglishVerification
npm run checkpasses (biome, tsgo, shrinkwrap, browser-smoke).npm testpasses (single pre-existing MCP-registration race flakes only under full-repo parallelism and passes in isolation, unrelated to this diff).rg -n "[가-힣]"over tracked source → zero matches.Summary by cubic
Translated all Korean text in source and tests to English, removing Hangul from the repo without changing behavior. Tests and type checks stay green; wide-character and UTF‑8 tests now use CJK samples to preserve behavior.
packages/coding-agentUI and tests.packages/tui(width, stdin/paste, IME, LaTeX), and updated fixtures inpackages/coding-agent(OpenAI thinking, Tistory HTML) andpackages/senpi-codemode(eval renderer).npm run checkandnpm testpass; repo now contains no Hangul.Written for commit 062e49c. Summary will update on new commits.