[pull] main from TryGhost:main#1258
Merged
Merged
Conversation
) ref https://linear.app/tryghost/issue/PLA-147 Local-dev hardening from a test-DX audit (ghost/core is fully on Vitest now): - **Service-probe timeout 400ms → 1s** (`vitest-globalsetup-services.ts`). The 400ms ceiling could falsely SKIP an adapter suite whose service is actually up: `socket.setTimeout` is an inactivity timeout, and the globalSetup probes while the event loop is briefly blocked (before forks spawn) — a ~500ms block made a live service read as "down". Reproduced the false-skip at 400ms / correct at 1s. When the service is down, connection-refused fires instantly regardless of the ceiling, so this adds zero latency to the skip path. - Refreshed 3 stale code comments referencing the deleted `test/utils/overrides.js`, and the AGENTS.md Testing section (corrected `test:e2e`, noted the sqlite adapter auto-skip, documented single-file DB watch).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )