[pull] develop from marktext:develop#117
Merged
Merged
Conversation
* fix: preserve Google Docs CSS formatting on paste * fix(muya): avoid duplicate paste formatting
) * fix(desktop): preserve RTL text direction in PDF and print export RTL documents (e.g. Persian) exported to PDF or printed came out left-aligned with reversed word order, even though the editor renders them right-to-left. #4553 added `dir` to the exporter's `<html>` shell, which works for the styled-HTML export (written to disk verbatim). But the PDF/print path feeds that HTML through `printer.renderMarkdown(html)`, which assigns it to `printContainer.innerHTML` — dropping the outer `<html dir=…>` wrapper so only body content survives. The print container is appended to `document.body` as a sibling of `.editor-wrapper` (which holds the live `dir`), so it inherits no direction and `printToPDF` prints it LTR. Propagate the direction onto the print container itself, mirroring how the editor applies `dir` to its wrapper. LTR stays implicit to keep existing exports unchanged. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> * test(desktop): cover RTL direction on the print container Pin that the PDF/print container carries `dir=rtl`/`auto` and stays implicit for LTR and the unset default (#4833). Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com> --------- Co-authored-by: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )