[pull] master from mozilla:master#417
Merged
Merged
Conversation
… getter This was added in PR 18972 and it became unused in PR 19085, however it was accidentally left behind.
…dler Given that the Promise returned by the `PDFDocument.prototype.getPage` method *always* resolves with a `Page` instance, checking that the page is defined isn't necessary; note https://github.com/mozilla/pdf.js/blob/3a093291135136f20babaf8d76c7dee3cc938515/src/core/document.js#L1702-L1723 Furthermore the `Page.prototype.collectAnnotationsByType` method is asynchronous, and thus it always returns a Promise, hence it's "pointless" to fallback to return an empty Array.
For checkbox and radio button fields, the export value can differ from the appearance-state name: the field's inheritable `Opt` array holds the real export values (used for non-Latin text, or values shared between buttons). We previously exposed the appearance-state name as the export value.
Resolve checkbox/radio export values from the 'Opt' entry
Remove the unused `HighlightOutline.prototype.classNamesForOutlining` getter
…page-check Remove unneeded check in the "GetAnnotationsByType" worker-thread handler
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )