[pull] main from withastro:main#625
Merged
Merged
Conversation
…operty highlighting (#17254) All 7 style injection patterns in the Astro TextMate grammar used end: '(?=</)' to detect </style>, but this end pattern could be blocked when the embedded CSS grammar had an active child pattern that hadn't terminated. CSS @Property's syntax: "<color>" descriptor triggers VS Code's CSS grammar to start a selector pattern, and the > in <color> gets consumed as a CSS child combinator. The selector never closes, so </style> is never detected. Script injection patterns were already fixed for this same class of issue in PR #15109 using a two-pattern approach (begin/end for single-line + begin/while for multi-line). The while pattern is evaluated at the start of each line before child patterns, making it immune to embedded grammar stuck states. This commit applies the same fix to all 7 style injection patterns. Also updates the dummy CSS grammar to include a minimal selector pattern that simulates VS Code's real CSS grammar behavior, so the bug is properly caught by snapshot tests. Fixes #16751
…compile` + `custom`) (#17099) * fix(cloudflare): respect custom `image.service` in compile mode * Update .changeset/cloudflare-compile-respect-image-service.md Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> * fix(cloudflare): also generate build-time images for `imageService: 'custom'` * Update .changeset/cloudflare-compile-respect-image-service.md Co-authored-by: Armand Philippot <git@armand.philippot.eu> * test(cloudflare): skip real-Sharp build-time image tests on Windows CI The default-Sharp and Sharp-backed build-time image tests invoke Astro's real Sharp native binary, which fails to load on the Windows CI runner (ERR_DLOPEN_FAILED). Skip those two on win32 while keeping full real-WEBP coverage on Linux/macOS. The Sharp-free user service runs everywhere. --------- Co-authored-by: Emanuele Stoppa <my.burning@gmail.com> Co-authored-by: Armand Philippot <git@armand.philippot.eu> Co-authored-by: Matthew Phillips <matthewphillips@cloudflare.com>
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…n Container API (#17261)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )