[pull] main from withastro:main#630
Merged
Merged
Conversation
Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
…#17325) * fix(build): prevent merging CSS chunks containing @import rules\n\nWhen mergeInlineCss concatenates inline CSS chunks into a single <style>\ntag, @import rules from page-specific components can end up after shared\ncomponent styles. Per CSS spec, @import rules must appear at the top of\na stylesheet or browsers silently ignore them.\n\nInstead of trying to hoist @import rules, simply skip merging any CSS\nchunk that contains @import. Those chunks remain as their own <style>\ntags, keeping @import at the top of their stylesheet.\n\nFixes #11950 * Add changeset for @import CSS merge fix --------- Co-authored-by: Matthew Phillips <matthew@matthewphillips.info> Co-authored-by: Matthew Phillips <matthewphillips@cloudflare.com>
…t collection dev (#17318) * fix: CSS module scoped-name hash mismatch with Lightning CSS in dev (#17312) Share the dev-css plugin's CSS content cache with the content asset propagation plugin so that `getStylesForURL()` can retrieve already-processed CSS for CSS modules without re-importing via `?inline`. The `?inline` suffix was included in the filename passed to Lightning CSS's hasher, producing a different scoped-name hash than the original import used by the component. * test: cover Lightning CSS module updates in dev * test: avoid shadowing cheerio helper * test: keep CI summary helper local --------- Co-authored-by: Matthew Phillips <matthew@matthewphillips.info>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )