[pull] main from Shopify:main#163
Merged
Merged
Conversation
…d expo-cli (#3796) * Pin CI dependencies: lock eas-cli and playwright via yarn.lock, remove deprecated expo-cli - Remove 'npm install -g expo-cli eas-cli' from all three jobs (test-skia-ios, test-skia-android, test-skia-web). expo-cli is deprecated upstream and the workflow already uses the local expo package via 'npx expo'. eas-cli is added as a devDependency instead. - Remove 'npm install -g playwright' from test-skia-web. playwright is added as a devDependency and invoked via 'yarn playwright'. - Replace all 'npx playwright' calls with 'yarn playwright'. - Add eas-cli@18.4.0 and playwright@1.59.0 as devDependencies so their full transitive dependency trees are locked by yarn.lock. npm install -g resolves the full transitive dependency tree from the npm registry at install time with no lockfile. eas-cli pulls ~394 transitive deps; expo-cli pulls ~986 (and is deprecated). npx is equally dangerous as it does the same resolution at runtime. Adding these tools as devDependencies locks the entire tree via yarn.lock. * Add yarn install step before playwright commands in test-skia-web The workflow checks out the repo but never ran yarn install, so node_modules didn't exist. yarn playwright requires node_modules to resolve the playwright binary from the lockfile. * Replace all npx expo calls with yarn expo npx has the same fetch-from-registry-without-lockfile risk as npm install -g. The test apps are created with yarn create expo-app, so expo is a local dependency and yarn expo works directly.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
See Commits and Changes for more details.
Created by
pull[bot] (v2.0.0-alpha.4)
Can you help keep this open source service alive? 💖 Please sponsor : )