Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion .gitignore
Original file line number Diff line number Diff line change
@@ -1,4 +1,3 @@
!**/glob-import/root/dir/node_modules
.DS_Store
.idea
.pnpm-store
Expand All @@ -13,6 +12,9 @@ dist
dist-ssr
explorations
node_modules
!**/glob-import/root/dir/node_modules
!**/fixtures/glob-exports/node_modules
!**/fixtures/glob-exports/node_modules/my-pkg/dist
playground-temp
temp
TODOs.md
Expand Down

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

25 changes: 25 additions & 0 deletions packages/vite/src/node/__tests__/optimizer/resolve.spec.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,25 @@
import path from 'node:path'
import { describe, expect, test } from 'vitest'
import { expandGlobIds } from '../../optimizer/resolve'

const fixtureRoot = path.join(import.meta.dirname, '../fixtures/glob-exports')

function makeConfig(root: string): any {
return {
root,
resolve: { preserveSymlinks: false },
packageCache: new Map(),
}
}

describe('expandGlobIds', () => {
test('skips null-valued exports (private subpath patterns)', () => {
const result = expandGlobIds('my-pkg/*', makeConfig(fixtureRoot))

expect(result).toContain('my-pkg')
expect(result).toContain('my-pkg/utils')
expect(result).toContain('my-pkg/public')
expect(result).not.toContain('my-pkg/private')
expect(result).not.toContain('my-pkg/also-private')
})
})
7 changes: 7 additions & 0 deletions packages/vite/src/node/config.ts
Original file line number Diff line number Diff line change
Expand Up @@ -1708,6 +1708,13 @@ export async function resolveConfig(

// load .env files
// Backward compatibility: set envDir to false when envFile is false
if (config.envFile === false) {
logger.warn(
colors.yellow(
'The `envFile` option is deprecated, please use `envDir: false` instead.',
),
)
}
let envDir = config.envFile === false ? false : config.envDir
if (envDir !== false) {
envDir = config.envDir
Expand Down
3 changes: 3 additions & 0 deletions packages/vite/src/node/optimizer/resolve.ts
Original file line number Diff line number Diff line change
Expand Up @@ -131,6 +131,9 @@ export function expandGlobIds(id: string, config: ResolvedConfig): string[] {
.filter(Boolean),
)
} else {
// null export value means the subpath is intentionally private/blocked
// https://nodejs.org/api/packages.html#subpath-patterns
if (exports[key] == null) continue
possibleExportPaths.push(key.slice(2))
}
}
Expand Down
Loading