Skip to content

perf(worker): Batch testrun processing for flake detection#873

Open
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing-dt9DZx
Open

perf(worker): Batch testrun processing for flake detection#873
sentry[bot] wants to merge 1 commit intomainfrom
seer/perf/batch-flake-processing-dt9DZx

Conversation

@sentry
Copy link
Copy Markdown
Contributor

@sentry sentry Bot commented Apr 20, 2026

Fixes WORKER-Y96. The issue was that: The process_flakes_for_commit function executes N+1 queries by fetching Testrun objects individually for each ReportSession within a loop.

  • Refactored flake processing to fetch all relevant testruns for a commit's uploads in a single batch.
  • Renamed get_testruns to get_testruns_for_uploads and updated it to accept a list of upload IDs.
  • Removed the process_single_upload function.
  • Consolidated Testrun.objects.bulk_update to a single call after processing all testruns, improving efficiency.

This fix was generated by Seer in Sentry, triggered automatically. 👁️ Run ID: 13573082

Not quite right? Click here to continue debugging with Seer.

Legal Boilerplate

Look, I get it. The entity doing business as "Sentry" was incorporated in the State of Delaware in 2015 as Functional Software, Inc. In 2022 this entity acquired Codecov and as result Sentry is going to need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Sentry can use, modify, copy, and redistribute my contributions, under Sentry's choice of terms.


Note

Medium Risk
Moderate risk: changes the query shape and batching behavior for Testrun updates, which could impact performance/memory on large commits and alter which rows get updated if upload lists are empty or large.

Overview
Refactors flake detection to batch-fetch all Testruns for a commit’s relevant uploads (via get_testruns_for_uploads(upload_ids)) instead of querying per-upload, eliminating the prior N+1 pattern.

Processing is consolidated into a single loop over the combined testruns with one bulk_update at the end, and the per-upload helper (process_single_upload) is removed; logging now records upload_ids rather than upload objects.

Reviewed by Cursor Bugbot for commit 1630373. Bugbot is set up for automated code reviews on this repo. Configure here.

@sentry
Copy link
Copy Markdown
Contributor Author

sentry Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 92.25%. Comparing base (0ad8a0c) to head (1630373).
✅ All tests successful. No failed tests found.

Additional details and impacted files
@@            Coverage Diff             @@
##             main     #873      +/-   ##
==========================================
- Coverage   92.25%   92.25%   -0.01%     
==========================================
  Files        1307     1307              
  Lines       48017    48011       -6     
  Branches     1636     1636              
==========================================
- Hits        44299    44293       -6     
  Misses       3407     3407              
  Partials      311      311              
Flag Coverage Δ
workerintegration 58.55% <6.66%> (+<0.01%) ⬆️
workerunit 90.38% <100.00%> (-0.01%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@codecov-notifications
Copy link
Copy Markdown

codecov-notifications Bot commented Apr 20, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ All tests successful. No failed tests found.

📢 Thoughts on this report? Let us know!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

0 participants