fix: enhance Logger PSR-3 compliance and interpolation reliability#10387
Open
gr8man wants to merge 4 commits into
Open
fix: enhance Logger PSR-3 compliance and interpolation reliability#10387gr8man wants to merge 4 commits into
gr8man wants to merge 4 commits into
Conversation
Contributor
|
Duplicate of #10384 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR addresses several issues in the
Logger::interpolate()method regarding PSR-3 compliance and interpolation robustness. Based on the community discussion here, passing an array or an unstringable object inside the$contextarray previously caused PHPE_WARNINGs (Array to string conversionorObject ... could not be converted to string) when parsed throughstrtr(). PSR-3 specifies that the context array can contain anything, so the logger should handle these types gracefully.Key Changes:
is_array()or is an unstringable object (is_object()without__toString()). If so, gracefully formats it usingprint_r($val, true)before interpolating, preventing runtime warnings.\StringableInterface Support: The$messageargument now correctly supports PHP 8.0\Stringableobjects, safely casting them to strings.preg_matchwithpreg_match_allwhen evaluating{env:foo}tags. Previously, only the very first environment variable tag in a log message was parsed. Now, multiple tags within the same message (e.g.{env:foo} and {env:baz}) are accurately matched and interpolated.Related issue/discussion: https://forum.codeigniter.com/showthread.php?tid=94242
Checklist: