Repository navigation
fix(svm): convert SPL/Jupiter amounts without float drift - #1609
Open
ninglinLiu wants to merge 1 commit into
Open
ninglinLiu wants to merge 1 commit into
ninglinLiu wants to merge 1 commit into
Conversation
Fractional amounts like 2.01 USDC produced non-integer floats via `amount * 10 ** decimals`, so BigInt threw and Jupiter quotes got a fractional amount. Route both through toTokenBaseUnits (decimal.js). Fixes coinbase#1574
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #1574.
SplActionProvider.transferandJupiterActionProvider.swapscaled human amounts withamount * 10 ** decimals. Binary floats cannot represent many decimal fractions, so values like2.01at 6 decimals become2009999.9999999998—BigInt(...)throws on SPL transfers, and Jupiter receives a non-integeramount.Adds
toTokenBaseUnits(viadecimal.js, already a dependency) and uses it in both action providers.Test plan
pnpm exec jest --testPathPattern=utils.test— covers2.01→2010000npnpm exec jest --testPathPattern=splActionProvider.test(src suite green)