fix(java): match package-private methods in Spring resolver#851
Open
Liurchen wants to merge 1 commit into
Open
fix(java): match package-private methods in Spring resolver#851Liurchen wants to merge 1 commit into
Liurchen wants to merge 1 commit into
Conversation
The method-matching regex only handled Kotlin `fun name(` and Java methods with explicit visibility modifiers (public/private/protected). Java package-private methods (no modifier) were silently skipped, breaking route-to-handler references for many Spring controllers. Add a third regex alternative that matches a return type followed by the method name: \b(?:[A-Z]\w*(?:<[^>]*>)?|void)\s+(\w+)\s*\( Verified on realworld-java21-springboot3: 4/19 -> 19/19 route-handler connections.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The method-matching regex only handled Kotlin
fun name(and Java methods with explicit visibility modifiers (public/private/protected). Java package-private methods (no modifier) were silently skipped, breaking route-to-handler references for many Spring controllers.Add a third regex alternative that matches a return type followed by the method name: \b(?:[A-Z]\w*(?:<[^>]>)?|void)\s+(\w+)\s(
Verified on realworld-java21-springboot3: 4/19 -> 19/19 route-handler connections.