Bind DB queue names and job payloads as text - #33
Merged
Merged
Conversation
elpete
marked this pull request as ready for review
September 8, 2026 12:47
elpete
added this pull request to stack #31
September 9, 2026 01:17
elpete
removed this pull request from stack #31
September 9, 2026 01:28
elpete
added this pull request to stack #36
September 9, 2026 01:29
elpete
force-pushed
the
perf/db-job-bindings
branch
from
September 9, 2026 01:39
ecec9cf to
5ed1cd5
Compare
elpete
force-pushed
the
perf/db-job-bindings
branch
from
September 9, 2026 01:44
5ed1cd5 to
2a432d5
Compare
elpete
force-pushed
the
perf/db-job-bindings
branch
from
September 9, 2026 02:00
2a432d5 to
a645322
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DBProvider.push currently asks qb to infer SQL types for every queue name and serialized job payload, even though both fields are text. Bind these two values explicitly as VARCHAR to avoid repeated numeric/date/type inference during native dispatch. Epoch timestamps, delays, attempt bindings, per-call query construction and provider lifecycle hooks retain their existing behavior.
Regression coverage exercises actual native inserts with long Unicode JSON, nested values, literal quote/backslash/newline characters, leading-zero queue names, delayed availability and bigint attempts. This PR is stacked on #32 (
fix/db-execution-counter-capacity).Validation at this candidate:
ecec9cf3e36bf01e6e621323f4815789d0d441e8, Lucee 5/6, Adobe 2021/2023/2025, formatting and security checks all pass. The final test uses literal text comparison for queue names.git diff --checkpass. The application subsequently adopts the exact Git package with all 32 runtime files matched against upstream and root qb unchanged; native installed-package verification remains application-specific follow-up.