Conversation
* fix: fence database callbacks to their execution attempt * test: align direct marshal fixture with persisted attempt * test: avoid literal array iteration on older Adobe engines
* fix: widen persisted job execution counter * fix: bind persisted execution counts as bigint * refactor: use unprefixed bigint parameter types
* perf(db): bind queue names and job payloads as text * test(db): compare queue names as literal text * fix(db): omit cf_sql prefix from text bindings
* feat(db): support opt-in batched job enqueueing * test(db): check numeric payload keys across engines
Record processed job IDs under the batch row lock, ignore repeated outcomes, and suppress duplicate lifecycle callbacks. Cover duplicate, concurrent, exhausted, and pre-migration batch cases. Refs #19. BREAKING CHANGE: Run migrations 2000_01_01_000010_widen_job_attempts and 2000_01_01_000011_track_processed_batch_jobs before deploying this version, including equivalent changes for custom tables. Drain pre-existing batches if successful job callbacks may be redelivered, since historical successful IDs cannot be reconstructed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Promote the database queue fixes and enqueue improvements from next to main.
Database callbacks are fenced to their execution attempt, retry counts support long-lived jobs, and unknown job mappings remain available for a compatible worker. Batch results are counted once per job ID so duplicate callbacks cannot decrement pendingJobs below zero or repeat lifecycle callbacks.
Database connections gain a configurable polling interval and opt-in batched enqueueing. Queue names and payloads are bound as text. Documentation covers MySQL compatibility, the bundled UUID library, worker routing, and upgrade requirements.
Upgrade: run migrations 000010 (widen job attempts) and 000011 (track processed batch jobs) before deploying, including equivalent changes for custom tables. Drain pre-existing batches if successful callbacks may be redelivered: historical successful job IDs cannot be reconstructed. The batch accounting commit (7db843d) places BREAKING CHANGE: in the third paragraph, as required by commandbox-semantic-release 3.0.1. Its actual parser and analyzer were exercised with the corrected message and returned isBreakingChange=true and releaseType=major.
Validation: constituent PR checks passed on Lucee 5/6 and Adobe 2021/2023/2025. This promotion will be merged only after its current head passes all checks.