Skip to content

libimage: clarify local image transport error #2549

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
Rajkaran-122 wants to merge 1 commit into from
Closed

libimage: clarify local image transport error #2549

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions libimage/image_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -188,6 +188,9 @@ func TestLookupImage(t *testing.T) {
runtime := testNewRuntime(t)
ctx := context.Background()

_, _, err := runtime.LookupImage("docker://busybox", nil)
require.EqualError(t, err, `unsupported transport "docker" for looking up local images; remove the transport prefix to refer to an image in local storage`)

pullOptions := &PullOptions{}
pullOptions.Writer = os.Stdout

Expand Down
2 changes: 1 addition & 1 deletion libimage/runtime.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ func (r *Runtime) LookupImage(name string, options *LookupImageOptions) (*Image,
storageRef, err := alltransports.ParseImageName(name)
if err == nil {
if storageRef.Transport().Name() != storageTransport.Transport.Name() {
return nil, "", fmt.Errorf("unsupported transport %q for looking up local images", storageRef.Transport().Name())
return nil, "", fmt.Errorf("unsupported transport %q for looking up local images; remove the transport prefix to refer to an image in local storage", storageRef.Transport().Name())
}
_, img, err := storageTransport.ResolveReference(storageRef)
if err != nil {
Expand Down
Loading