Conversation
florinutz
force-pushed
the
flo/833/connect-probe
branch
from
September 18, 2026 11:44
29478db to
ec23054
Compare
Version detection moves to first read, so an early connection works again.
florinutz
force-pushed
the
flo/833/connect-probe
branch
from
September 18, 2026 12:48
ec23054 to
7470717
Compare
florinutz
marked this pull request as ready for review
September 18, 2026 12:49
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With this changeset,
connect()now takes aprobeargument that defaults toTrue. In this case, the servers are contacted while the connection is created, andConnectionErroris raised when none of them responds. This would be what 2.3.0 does.With
probe=False, creating the connection performs no request.lowest_server_versionis resolved when something first reads it, and reading it raisesConnectionErrorwhile no server responds. A caller that never reads it talks to the cluster on the first statement, as before 2.3.0.This gives callers (that talk to a cluster which is starting or shutting down) a way back. crate's blackbox tests pinned
crate<2.3for that reason in crate/crate#20233, and CI service containers have the same race. So these callers would passprobe=Falseto every connect() that causes troubles, and this would just use the previous behavior instead of the one introduced in 2.3.0.Closes #833.