Repository navigation
feat: streamline compact reviews with input compatibility proof - #26
Merged
Merged
Conversation
Require executable legacy-input evidence before scope freezes and assign domain input adversary checks to the existing side-effects lens. Let one fresh compact reviewer cover every lens and the final adversarial diff on unchanged source, while retaining the full route and all proof/authority rules. Narrow confirmed tripwire false positives without masking credential-boundary removal, add real approval regressions, and document an executed Windows preflight using process-scoped configuration and space-preserving arguments. Constraint: Preserve three lens verdicts, source freshness, and approval authority Confidence: medium Scope-risk: moderate Not-tested: Native symlink creation unavailable locally; held-out comparison pending
cskwork
changed the base branch from
fix/verification-proof-integrity
to
main
October 11, 2026 18:01
cskwork
marked this pull request as ready for review
October 11, 2026 18:01
This was referenced Oct 11, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The current compact contract requires multiple independent review contexts, while an assumed input schema can exclude records the original application accepts. Require executable caller/legacy-input evidence before scope freezes and let one independent compact reviewer cover every verification lens and the final adversarial diff on unchanged source. Full-route review remains separate; scenario floors, approval authority, source freshness and retry caps remain required.
The existing Side effects lens now owns domain-specific missing, empty, null, wrong-type and unknown-value probes. Reviewer reports retain actual execution evidence or explicit unknowns, and current proof can be reused only with matching inputs. Windows guidance includes a saved-script preflight executed with spaced paths and process-scoped settings.
The tripwire fix removes confirmed authorization/prohibition false positives while preserving mixed risk and quoted, same-line and multiline removal of credential restrictions. Regression coverage exercises the real approval command; no gate, test or source-integrity check was weakened.
Stacked on open #25.
Validation at candidate
f15658f0a7653b14608904f7f36eb8a652bcb1fc:54f5cb4fb652e46178e0b77ae9a6c2cf92fa12884bd6d7303b151e8761b2e9fb.First-pass time is the first captured immutable snapshot passing the frozen finite suite, with 15-second capture cadence and last-failed intervals retained; it is not exact completion time or proof of no other bugs. Revised kit's pooled median parent elapsed is 8.2% lower than current kit's, but first pass is 27.3% later. Recovery is descriptively faster; the feature is slower and includes the timeout. Revised kit remains about 9.9× no-kit's median total time, with no measured correctness advantage.
Independent audit: mechanical completion is no-kit 6/6, current-kit 6/6, revised-kit 5/6; useful participant test execution and final test/approval source binding are proved for all 18. Full workflow is six true for no-kit, six unknown for current kit, and five unknown/one false for revised kit. Native helper waits lack child IDs/prompts/responses; written PASS reports cannot authenticate reviewer execution. This interface may conceal real helper activity, so missing receipts are neither zero helpers nor synthetic failures. Four catalog runs replaced a dedicated original export case; replacement coverage may subsume its behavior, so semantic weakening remains unknown and product acceptance is unchanged.
The methods audit preserved all frozen tooling/packages, 90 observations and 1,196 archived file hashes. All runs are serial and cleanup is confirmed. Normal user configuration changed after freeze; actual invocations explicitly ignored user configuration and matched all explicit controls, but complete effective-prompt identity is unproved. Parent-only usage is incomplete for the timeout; helper totals and billing are unavailable. These are descriptive results from three trials per task/arm, not a significance or cost claim.
The user authorized merging validated source fixes to main. These two modest tasks still do not establish that the revised workflow beats baseline; no universal quality, speed, cost or allowance advantage is claimed. The negative comparison and verification limits remain part of this PR.