Chapters 10 and 13 - #69
Open
felipponn wants to merge 16 commits into
Open
Conversation
Under the current Lean/Mathlib toolchain, `simp only [..., decide_eq_true_eq, <proj-lemmas>]` no longer strips `decide P = true` to `P` when projection rfl-lemmas (`residue`/`count`/`value_add`/`weight_add`) are unfolded in the same call: `decide_eq_true_eq` is reported unused and the goal stays wrapped in `decide (…) = true`, so the following `constructor` / `calc` / `⟨_, _⟩` steps fail (no `And` constructor; `calc` type mismatch; `Eq.refl` given 2 fields). Fix: strip the `decide` in its own `simp only [_, decide_eq_true_eq]` pass first, then unfold the projections in a second step. Three sites across the two `key_fact` theorems (coin-change and knapsack). No statements changed; the whole `Fad` library builds again (8696 jobs, 0 errors). Co-Authored-By: Claude Opus 4.8 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01AbkMyCwYRAiUy3NFwn9M4f
Member
|
|
Member
|
@felipponn, I couldn't find the example you showed me using the Query model. Can you double-check whether you submitted it? |
Author
|
@BXimenaGomez123, could we review the existing code and consider switching the |
arademaker
reviewed
Sep 11, 2026
| @@ -1,6 +1,9 @@ | |||
| import Fad.Chapter1 | |||
| import Fad.Chapter10 | |||
| import Fad.API | |||
Member
There was a problem hiding this comment.
This can be avoided. We can follow Chapter2, using directly the CSLib definitions already available, we import it.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
In this pull request, we use the
TimeMmonad and systematically extends the codebase to support time complexity analysis for algorithms in Chapter 13, including Fibonacci, binomial coefficients, and the knapsack problem.Beyond that, we create the structure for Chapter 10, choosing to implement the
ThinBymulti-function as a predicate. All sections are implemented, and some exercises are suggested.