Skip to content

Bootstrap upgrade - #635

Merged
abeverley merged 49 commits into
ctrlo:dev-bootstrapfrom
droberts-ctrlo:bootstrap-upgrade
Jul 29, 2026
Merged

Bootstrap upgrade#635
abeverley merged 49 commits into
ctrlo:dev-bootstrapfrom
droberts-ctrlo:bootstrap-upgrade

Conversation

@droberts-ctrlo

Copy link
Copy Markdown
Contributor

No description provided.

@droberts-ctrlo
droberts-ctrlo marked this pull request as draft June 18, 2026 10:13
@droberts-ctrlo
droberts-ctrlo marked this pull request as ready for review June 19, 2026 08:33
@droberts-ctrlo

Copy link
Copy Markdown
Contributor Author

Cypress tests are failing as they now do not automatically confirm dialogs - when running the tests interactively, they pass fine within both local and container environments.

The aim is to get all tests passing as another PR, including all unit tests that are currently skipped.

@droberts-ctrlo droberts-ctrlo changed the title Bootstrap upgrade Bootstrap upgrade (internal maintenance) Jun 19, 2026
@droberts-ctrlo droberts-ctrlo changed the title Bootstrap upgrade (internal maintenance) Bootstrap upgrade Jun 19, 2026

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR reviewed - some minor comments added.

Comment thread src/frontend/components/markdown/lib/component.js Outdated
Comment thread src/frontend/components/modal/lib/component.js Outdated
Comment thread src/frontend/components/data-table/_data-table-toggle.scss Outdated
Comment thread src/frontend/components/data-table/_data-table.scss Outdated
Comment thread src/frontend/components/data-table/_data-table.scss Outdated

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes to PR reviewed - all is well.

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest changes to PR reviewed - all seems well.

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated PR reviewed - all seems well.

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Latest update to PR reviewed - all is well.

@pwlodarski-ctrlo pwlodarski-ctrlo left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR re-re-reviewed - minor comments added.

Comment thread changelist.md
Comment thread lib/GADS.pm
Comment thread VERSION
@droberts-ctrlo

Copy link
Copy Markdown
Contributor Author

Relies on #642

Updated error handler
…changed

Removed cjs from eslint - cjs are used for internal development files, and should never be included
… dev branch

Updated files where dev changes weren't included
Updated documentation

Fixed formatting and code where this was broken on merge with current dev branch

Added fix for error on documentComponent

Updated code files with changes as required where they were included in dev

Updated file where missing function wasn't included
Further package changes and TSConfig updates

Removed knip
Updated code files with changes as required where they were included in dev
Updated to use new switch component for fullscreen
Updated formatting as this didn't update on prev commit properly
Fixed cypress tests
Updated as per testing results

Further changes due to buttons not displaying correctly

Updated package file
Comment thread src/frontend/components/data-table/lib/component.js
Comment thread src/frontend/components/data-table/lib/component.js
Comment thread src/frontend/fonts/bootstrap-icons/bootstrap-icons.woff Outdated
Comment thread src/frontend/js/lib/util/formatters/markdown.ts Outdated
Comment thread views/fields/sub/popover.tt Outdated
Comment thread views/fields/daterange.tt Outdated
Comment thread views/navigation/breadcrumbs.tt Outdated
Comment thread views/edit.tt
Comment thread views/edit.tt
Comment thread views/layout.tt
Comment thread views/layout.tt
Comment thread views/table.tt
Comment thread views/view.tt Outdated
@abeverley
abeverley merged commit dd2f533 into ctrlo:dev-bootstrap Jul 29, 2026
7 of 12 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants