Add TCP keepalive socket options#124
Open
hownowstephen wants to merge 1 commit intomainfrom
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
TCPKeepAliveHTTPAdapterSO_KEEPALIVE,TCP_KEEPIDLE(300s), andTCP_KEEPINTVL(60s) to match server-side configurationBased on #70 by @zaf, rebased onto current main. Closes #70.
Test plan
test_keepalive_socket_options_are_configured_on_adapterverifies options set correctlyNote
Medium Risk
Changes the HTTP transport adapter used for all HTTPS requests, which can affect connection reuse and behavior across platforms (different socket options availability). Impact is limited to client networking settings and covered by a targeted unit test.
Overview
Enables TCP keepalive on all outbound HTTPS requests by replacing the default
HTTPAdapterwith a customTCPKeepAliveHTTPAdapterthat injects keepalive-relatedsocket_optionsinto both direct and proxy connection pools.Adds configurable constants for keepalive timing (idle 300s, interval 60s) and a new test (
test_keepalive_socket_options_are_configured_on_adapter) asserting the adapter preserves urllib3 defaults while adding the keepalive options when supported by the OS.Reviewed by Cursor Bugbot for commit b4ebb98. Bugbot is set up for automated code reviews on this repo. Configure here.