ci: use dappnode-build-hash reusable workflow#49
Merged
Conversation
Replaces the inlined build-test (which used `--skip_save` and never posted an IPFS hash on PRs) with a thin caller for the new `dappnode/workflows/.github/workflows/dappnode-build-hash.yml@master` reusable workflow. `build.yml` (new) handles both push and workflow_dispatch; `main.yml` is reduced to the release job only. Also: - Upgrades `actions/checkout` to v7 and Node 24 (with `actions/setup-node@v6`) for the release job. - Drops the redundant `if:` condition on the release job (the `on.push.branches` filter already restricts to master/v*). - Adds `repository_dispatch` to the `on:` triggers. - Adds `branches-ignore: ["master"]` to `build.yml`'s push trigger so the workflow doesn't run on default-branch pushes (the SDK already auto-detects and does a no-op test build in that case). The reusable workflow auto-detects the event: on push to a non-default branch it builds, pins to Pinata, and posts a comment authored by tropibot[bot] on the PR; on push to the default branch it does a test build only. `workflow_dispatch` and `repository_dispatch` only fire the release job (no `build.yml` trigger).
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: 1f2cdb5 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This repo'''s build pipeline (an inlined
build-teststep with--skip_save) never pinned to IPFS or posted a comment on PRs, so tropibot bumps had no installable artifact for testers.Approach
.github/workflows/build.yml(new) — thin stub callingdappnode-build-hash@masterwithsecrets: inherit. Triggers onpush(non-default branch) andworkflow_dispatchonly..github/workflows/main.yml— slimmed to the release job only.build-testremoved;actions/checkoutupgraded to v7;actions/setup-nodeto v6; Node 24. Dropped the redundantif:condition (theon.push.branchesfilter already restricts to master/v*). Addedrepository_dispatchto triggers.Test instructions
Buildworkflow runs once and posts a comment with an IPFS install link and hash tagged(by dappnodebot/build-action)and authored bytropibot[bot].Mainworkflow should run the release.