ci: use dappnode-build-hash reusable workflow#160
Merged
Conversation
Replaces the inlined build step (which used `--skip_save` and never posted an IPFS hash on PRs) with a thin caller for the new `dappnode/workflows/.github/workflows/dappnode-build-hash.yml@master` reusable workflow. `build.yml` now handles both push and PR events; `main.yml` is reduced to the release job only. Also upgrades `actions/checkout` to v7 and adds Node 24 setup for the release job.
Contributor
|
Dappnode bot has built and pinned the built packages to an IPFS node, for commit: fbfa7a3 This is a development version and should only be installed for testing purposes.
Hash: (by dappnodebot/build-action) |
The `push` event already fires when tropibot pushes commits to the feature branch, so the build, IPFS pin, and PR comment all happen once per commit. The `pull_request` event was firing the same workflow a second time as a no-op (--skip_save test build). The reusable workflow SDK auto-detects the event: `push` to a non-default branch builds + pins + comments, `push` to default does a test build, and (now unused) `pull_request` would do a test build.
The release job had a broad `on.push` (no branch filter) plus an `if:` condition that checked `github.event_name`. This was redundant: the trigger already filters by branch (or by event type for repository_dispatch / workflow_dispatch), and the if condition just re-checked the event type. Simplify: keep the trigger filters, drop the if. Also ensure `repository_dispatch` is in the trigger list for repos that referenced it in their if condition.
`build.yml` triggers on `push` and `workflow_dispatch`. The reusable `dappnode-build-hash.yml` SDK already auto-detects pushes to the default branch and runs a no-op test build (no IPFS pin, no comment), so the workflow run is wasted CI on every merge. Add `branches-ignore: ["master"]` to the push trigger so the workflow doesn't even start on default-branch pushes. `workflow_dispatch` and pushes to other branches (e.g. tropibot bump branches) still trigger it as before.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Context
This repo's build pipeline (either an inlined
build-teststep with--skip_saveor an inlinednpx dappnodesdk github-action buildcall) is now consolidated into a thin caller for the newdappnode/workflows/.github/workflows/dappnode-build-hash.yml@masterreusable workflow. This produces a properly tagged IPFS hash comment on every push to a non-default branch and on every PR.Approach
.github/workflows/build.yml— thin stub callingdappnode-build-hashwithsecrets: inherit..github/workflows/main.yml— slimmed to the release job only.build-testremoved;actions/checkoutupgraded to v7; Node 24 added.pull_requesttrigger is moved frommain.ymltobuild.yml(the new reusable workflow handles both events).Test instructions
Buildworkflow runs and posts a comment with an IPFS install link and hash tagged(by dappnodebot/build-action).Mainworkflow should run the release.