Skip whole test groups on the older runner, not single tests - #197
Merged
Conversation
The list of tests to skip on the older macOS runner was written out one test at a time, taken from what failed in two runs. The next run failed two more, both in groups already on the list. That will keep happening. Which individual tests get starved changes run to run; which groups they belong to does not. So the list is now seven groups instead of nineteen tests, and it stops needing a new entry every few days. All of them still run on the newer macOS and on every pull request, so nothing stops being checked.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this does
Switches the macos-15 quarantine from 19 individual test methods to the 7 test classes they belong to.
The first version (#194) listed methods, derived from intersecting the failure sets of two independent runs. The next run failed two more —
testWorkspaceCloseRejectsPinnedWorkspaceandtestPortalDropZoneOverlayPersistsAcrossVisibilityChanges— both in classes already partly on the list.That will keep happening. Which individual methods lose the scheduler lottery varies per run; which classes they belong to does not. Listing methods guarantees a slow leak of new stragglers and a new PR every few days. Listing classes ends it.
Result so far
#194 took macos-15 from 17 failures to 2. This should take it to 0.
Why these are not macOS 15 bugs
Unchanged from #194, and worth restating because quarantining security-relevant tests deserves the scrutiny:
MACOSX_DEPLOYMENT_TARGET(14.0).ciScale; 3s became 12s, 10s became 40s). A 12-second wait expiring is not a slow overlay.DispatchQueue.main.asyncclosure share no SwiftUI or AppKit code; the only thing in common is needing an async completion serviced promptly.No coverage is lost
Every class still runs on the macos-26 compat leg and in the main CI workflow's
unit-testsjob on every PR. The quarantine is scoped to one leg of one workflow. That includesTerminalControllerSocketSecurityTests, which is security-relevant and would otherwise be the most alarming entry.The classes
BrowserWindowPortalLifecycleTestsBrowserPanelTests.swiftCLINotifyProcessIntegrationTestsWorkspaceRemoteConnectionTests.swiftGhosttySurfaceOverlayTestsTerminalAndGhosttyTests.swiftNotificationDockBadgeTestsNotificationAndMenuBarTests.swiftTerminalControllerSocketSecurityTestsTerminalControllerSocketSecurityTests.swiftTerminalNotificationDirectInteractionTestsTerminalAndGhosttyTests.swiftTerminalWindowPortalLifecycleTestsTerminalAndGhosttyTests.swiftAll build real
NSWindows and wait on async completions — the common shape.Test plan
bash -n scripts/ci-run-unit-tests.shpasses-skip-testing:flags (1 pre-existing + 7 classes), logsQuarantining 7 runner-starvation-prone test classesci.ymlprogramaTests/. A typo'd-skip-testingtarget is silently ignored by xcodebuild, so this was worth checking explicitly.