ENH: add check_namespace to testing utilities#720
Closed
prady0t wants to merge 2 commits into
Closed
Conversation
Signed-off-by: Pradyot Ranjan <99216956+pradyotRanjan@users.noreply.github.com>
prady0t
changed the title
lucascolley
changed the title
check_namespace to testing utilities
lucascolley
reviewed
May 13, 2026
Member
lucascolley
left a comment
lucascolley
left a comment
There was a problem hiding this comment.
@prady0t actually, I just went back to gh-267 and read:
I decided not to add a
check_namespacetoggle: ifcheck_namespaceis False and the namespaces don't match, other operations might fail. I didn't want to work on fixing this if it's not an important feature. There is only one file in SciPy that usescheck_namespace=False, and it probably shouldn't.
Maybe we just want to close this?
Contributor
Author
|
Ah. Good point indeed. Let's close this. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #719
Towards #17