Persist state to .wal immediately after resource update#5149
Open
denik wants to merge 84 commits into
Open
Conversation
Move kill-on-request behavior from test.toml fields (KillCaller, KillCallerOffset) to a POST /__testserver/kill endpoint. Kill rules are scoped by auth token so concurrent tests sharing a server don't interfere. acceptance/bin/kill_after.py is a convenience wrapper that posts to the endpoint, keeping scripts readable. The kill check is applied at the HTTP middleware layer (wrapping the entire router) so it fires for all requests, including those that would otherwise fall through to the not-found handler. Co-authored-by: Isaac
Co-authored-by: Isaac
…files Co-authored-by: Isaac
Co-authored-by: Isaac
…y test.toml files Co-authored-by: Isaac
- acceptance/bundle/deploy/wal/crash-after-create/test.toml and lineage-mismatch/test.toml were untracked; scripts using $COMMAND failed with "unbound variable" on CI - assert_exists.py and assert_not_exists.py were tracked as 100644; CI ran them as non-executable, producing "Permission denied" errors Co-authored-by: Isaac
… Windows
Multiline TOML basic strings (""") use literal newlines from the file.
On Windows with autocrlf=true, these become CRLF. After NormalizeNewlines
strips \r from the test output, the replacement re-introduces \r via the
New string, causing the comparison to fail.
Using single-line basic strings with \n escapes ensures the newlines in the
replacement are always LF regardless of platform.
Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
…tial progress Co-authored-by: Denis Bilenko <denis.bilenko@databricks.com>
Contributor
Approval status: pending
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Every time we update a state, we now write resource entry to resources.json.wal. At the end of the deployment, we read those entries, merge them into state and write state file.
Internally, the state file can be opened in two modes: read and write. In write mode we only track IDs in memory but not full state. This ensures that when we merge .wal file into state in-memory representation, the .wal file is source of truth, so normal state update is not different from recovery state-update.
Why
If "bundle deploy" is killed, we don't lose state changes. Next time any bundle command runs, we'll recover the updates.
Tests
Modified testserver kill API to be more flexible. Instead of being configured via test.toml, it's a separate endpoint that can add kill middleware on any other endpoint. So you can dynamically insert kill action during script execution.