Persist scheme-less account login hosts as HTTPS#5727
Draft
50sotero wants to merge 1 commit into
Draft
Conversation
Scheme-less account-console hosts are valid user input during login, but persisting them without https:// leaves later account commands unable to build a valid account configuration. Normalize only classic accounts.* login hosts after existing slash trimming so arbitrary workspace hosts and test placeholders keep their current spelling. Constraint: User input may omit the URL scheme for accounts.cloud.databricks.com. Rejected: Canonicalize every login host | broader behavior change for workspace aliases and existing placeholder inputs. Confidence: high Scope-risk: narrow Reversibility: clean Directive: Keep login host normalization conservative unless profile matching and saved config compatibility are tested together. Tested: go test ./cmd/auth -run TestSetHost -count=1 Tested: go test ./cmd/auth -count=1 Related: databricks#1403
Contributor
|
An authorized user can trigger integration tests manually by following the instructions below: Trigger: Inputs:
Checks will be approved automatically on success. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes
Fixes #1403
Tests